Bugzilla – Attachment 61720 Details for
Bug 18349
Possibility to checkout/renew bypassing the circ rules using SCO
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18349: Remove unused $issuenoconfirm var
Bug-18349-Remove-unused-issuenoconfirm-var.patch (text/plain), 1.59 KB, created by
Jonathan Druart
on 2017-03-29 21:43:09 UTC
(
hide
)
Description:
Bug 18349: Remove unused $issuenoconfirm var
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2017-03-29 21:43:09 UTC
Size:
1.59 KB
patch
obsolete
>From 368347c670fb6cf01dae2b375cb6f9b1fcb40474 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 29 Mar 2017 18:34:48 -0300 >Subject: [PATCH] Bug 18349: Remove unused $issuenoconfirm var > >--- > opac/sco/sco-main.pl | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) > >diff --git a/opac/sco/sco-main.pl b/opac/sco/sco-main.pl >index dc50610..982581a 100755 >--- a/opac/sco/sco-main.pl >+++ b/opac/sco/sco-main.pl >@@ -104,8 +104,6 @@ my ($op, $patronid, $patronlogin, $patronpw, $barcode, $confirmed) = ( > $query->param("confirmed") || '', > ); > >-my $issuenoconfirm = 1; #don't need to confirm on issue. >-#warn "issuerid: " . $issuerid; > my $issuer = GetMember( borrowernumber => $issuerid ); > my $item = GetItem(undef,$barcode); > if (C4::Context->preference('SelfCheckoutByLogin') && !$patronid) { >@@ -196,14 +194,8 @@ elsif ( $op eq "checkout" ) { > $template->param(amount => $currencySymbol.$needconfirm->{DEBT}); > } > } else { >- if ( $confirmed || $issuenoconfirm ) { # we'll want to call getpatroninfo again to get updated issues. >- # warn "issuing book?"; >+ if ( $confirmed ) { # we'll want to call getpatroninfo again to get updated issues. > AddIssue( $borrower, $barcode ); >- # ($borrower, $flags) = getpatroninformation(undef,undef, $patronid); >- # $template->param( >- # patronid => $patronid, >- # validuser => 1, >- # ); > } else { > $confirm_required = 1; > #warn "issue confirmation"; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18349
:
61719
|
61720
|
61755
|
61756
|
61757
|
61908
|
61909
|
61910
|
61911
|
61959