Bugzilla – Attachment 61936 Details for
Bug 18384
Add syspref to show all subs attached to a biblio in serial collection by default
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18384: ShowAllAttachedSubsSerialCollection syspref
Bug-18384-ShowAllAttachedSubsSerialCollection-sysp.patch (text/plain), 4.51 KB, created by
Claire Gravely
on 2017-04-06 09:19:43 UTC
(
hide
)
Description:
Bug 18384: ShowAllAttachedSubsSerialCollection syspref
Filename:
MIME Type:
Creator:
Claire Gravely
Created:
2017-04-06 09:19:43 UTC
Size:
4.51 KB
patch
obsolete
>From 261233a70f59fd210ff6a05d72def5333f961a9b Mon Sep 17 00:00:00 2001 >From: Aleisha Amohia <aleishaamohia@hotmail.com> >Date: Wed, 5 Apr 2017 00:13:38 +0000 >Subject: [PATCH] Bug 18384: ShowAllAttachedSubsSerialCollection syspref > >To test: >1) Apply patch and update database >2) Find ShowAllAttachedSubsSerialCollection syspref, confirm it is set >to "Don't" >3) Go to Serials, find a serial with more than one subscription >4) Click Serial Collection, confirm you are taken to the subscription >summary for that one subscription >5) Set syspref to 'Always' >6) Go back to serials and find that same serial >7) Click Serial Collection, confirm you can see the subscription >summaries of all attached subs straight away. > >Sponsored-by: Catalyst IT >Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> >--- > .../bug_18384_-_add_ShowAllAttachedSubsSerialCollection_syspref.sql | 1 + > installer/data/mysql/sysprefs.sql | 1 + > koha-tmpl/intranet-tmpl/prog/en/includes/serials-menu.inc | 6 +++++- > .../intranet-tmpl/prog/en/modules/admin/preferences/serials.pref | 6 ++++++ > 4 files changed, 13 insertions(+), 1 deletion(-) > create mode 100644 installer/data/mysql/atomicupdate/bug_18384_-_add_ShowAllAttachedSubsSerialCollection_syspref.sql > >diff --git a/installer/data/mysql/atomicupdate/bug_18384_-_add_ShowAllAttachedSubsSerialCollection_syspref.sql b/installer/data/mysql/atomicupdate/bug_18384_-_add_ShowAllAttachedSubsSerialCollection_syspref.sql >new file mode 100644 >index 0000000..60b15b6 >--- /dev/null >+++ b/installer/data/mysql/atomicupdate/bug_18384_-_add_ShowAllAttachedSubsSerialCollection_syspref.sql >@@ -0,0 +1 @@ >+INSERT IGNORE INTO systempreferences (`variable`, `value`, `options`, `explanation`, `type`) VALUES ('ShowAllAttachedSubsSerialCollection', '0', NULL, 'If enabled, always show all attached subscriptions to a biblio in serial collection', 'YesNo'); >diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql >index 7e249b7..f3cbca1 100644 >--- a/installer/data/mysql/sysprefs.sql >+++ b/installer/data/mysql/sysprefs.sql >@@ -472,6 +472,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('ShelfBrowserUsesCcode','1','0','Use the item collection code when finding items for the shelf browser.','YesNo'), > ('ShelfBrowserUsesHomeBranch','1','1','Use the item home branch when finding items for the shelf browser.','YesNo'), > ('ShelfBrowserUsesLocation','1','1','Use the item location when finding items for the shelf browser.','YesNo'), >+('ShowAllAttachedSubsSerialCollection', '0', NULL, 'If enabled, always show all attached subscriptions to a biblio in serial collection', 'YesNo'), > ('ShowAllCheckins', '0', '', 'Show all checkins', 'YesNo'), > ('ShowPatronImageInWebBasedSelfCheck','0','','If ON, displays patron image when a patron uses web-based self-checkout','YesNo'), > ('ShowReviewer','full','none|full|first|surname|firstandinitial|username','Choose how a commenter\'s identity is presented alongside comments in the OPAC','Choice'), >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/serials-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/serials-menu.inc >index 21dff3a..3c5d269 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/serials-menu.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/serials-menu.inc >@@ -1,6 +1,10 @@ > [% IF ( subscriptionid ) %] > <ul> >-<li><a href="serials-collection.pl?subscriptionid=[% subscriptionid %]">Serial collection</a></li> >+ [% IF Koha.Preference('ShowAllAttachedSubsSerialCollection') %] >+ <li><a href="/cgi-bin/koha/serials/serials-collection.pl?biblionumber=[% bibnum %]">Serial collection</a></li> >+ [% ELSE %] >+ <li><a href="/cgi-bin/koha/serials/serials-collection.pl?subscriptionid=[% subscriptionid %]">Serial collection</a></li> >+ [% END %] > [% UNLESS closed %] > [% IF ( routing && CAN_user_serials_routing ) %] > [% IF ( hasRouting ) %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/serials.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/serials.pref >index 76c89a8..af674d2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/serials.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/serials.pref >@@ -1,5 +1,11 @@ > Serials: > - >+ - pref: ShowAllAttachedSubsSerialCollection >+ choices: >+ yes: Always >+ no: "Don't" >+ - show all attached subscriptions to a biblio in Serial Collection. >+ - > - Show > - pref: opacSerialDefaultTab > choices: >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18384
:
61860
|
61936
|
64380