From 0c18e2fb25c276f06e5250fdce5af213e82f1698 Mon Sep 17 00:00:00 2001
From: Nick Clemens <nick@bywatersolutions.com>
Date: Thu, 6 Apr 2017 11:02:54 -0400
Subject: [PATCH] Bug 14576 (QA Followup) Fix warnings in tests

---
 t/db_dependent/Circulation/Returns.t | 8 ++++----
 t/db_dependent/Circulation/issue.t   | 1 +
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/t/db_dependent/Circulation/Returns.t b/t/db_dependent/Circulation/Returns.t
index 61cefc6..761befb 100644
--- a/t/db_dependent/Circulation/Returns.t
+++ b/t/db_dependent/Circulation/Returns.t
@@ -17,7 +17,7 @@
 
 use Modern::Perl;
 
-use Test::More tests => 4;
+use Test::More tests => 3;
 use Test::MockModule;
 use Test::Warn;
 
@@ -121,11 +121,11 @@ subtest "AddReturn logging on statistics table (item-level_itypes=1)" => sub {
 
     is( $stat->itemtype, $ilevel_itemtype,
         "item-level itype recorded on statistics for return");
-    warning_like { AddIssue( $borrower, $item_without_itemtype->{ barcode } ) }
-                 qr/^item-level_itypes set but no itemtype set for item/,
+    warnings_like { AddIssue( $borrower, $item_without_itemtype->{ barcode } ) }
+                 [qr/^item-level_itypes set but no itemtype set for item/,qr/^item-level_itypes set but no itemtype set for item/,qr/^item-level_itypes set but no itemtype set for item/],
                  'Item without itemtype set raises warning on AddIssue';
     warnings_like { AddReturn( $item_without_itemtype->{ barcode }, $branch ) }
-                [qr/^item-level_itypes set but no itemtype set for item/,qr/^item-level_itypes set but no itemtype set for item/],
+                [qr/^item-level_itypes set but no itemtype set for item/,qr/^item-level_itypes set but no itemtype set for item/,qr/^item-level_itypes set but no itemtype set for item/],
                  'Item without itemtype set raises warnings on AddReturn';
     # Test biblio-level itemtype was recorded on the 'statistics' table
     $stat = $schema->resultset('Statistic')->search({
diff --git a/t/db_dependent/Circulation/issue.t b/t/db_dependent/Circulation/issue.t
index d471d42..d1158fc 100644
--- a/t/db_dependent/Circulation/issue.t
+++ b/t/db_dependent/Circulation/issue.t
@@ -372,6 +372,7 @@ my $itemnumber2;
         homebranch     => $branchcode_1,
         holdingbranch  => $branchcode_1,
         location => 'FIC',
+        itype          => $itemtype
     },
     $biblionumber
 );
-- 
2.1.4