Bugzilla – Attachment 61950 Details for
Bug 14576
Allow automatic update of location on checkin
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14576 (QA Followup) Fix warnings in tests
Bug-14576-QA-Followup-Fix-warnings-in-tests.patch (text/plain), 2.40 KB, created by
Nick Clemens
on 2017-04-06 15:38:21 UTC
(
hide
)
Description:
Bug 14576 (QA Followup) Fix warnings in tests
Filename:
MIME Type:
Creator:
Nick Clemens
Created:
2017-04-06 15:38:21 UTC
Size:
2.40 KB
patch
obsolete
>From 0c18e2fb25c276f06e5250fdce5af213e82f1698 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Thu, 6 Apr 2017 11:02:54 -0400 >Subject: [PATCH] Bug 14576 (QA Followup) Fix warnings in tests > >--- > t/db_dependent/Circulation/Returns.t | 8 ++++---- > t/db_dependent/Circulation/issue.t | 1 + > 2 files changed, 5 insertions(+), 4 deletions(-) > >diff --git a/t/db_dependent/Circulation/Returns.t b/t/db_dependent/Circulation/Returns.t >index 61cefc6..761befb 100644 >--- a/t/db_dependent/Circulation/Returns.t >+++ b/t/db_dependent/Circulation/Returns.t >@@ -17,7 +17,7 @@ > > use Modern::Perl; > >-use Test::More tests => 4; >+use Test::More tests => 3; > use Test::MockModule; > use Test::Warn; > >@@ -121,11 +121,11 @@ subtest "AddReturn logging on statistics table (item-level_itypes=1)" => sub { > > is( $stat->itemtype, $ilevel_itemtype, > "item-level itype recorded on statistics for return"); >- warning_like { AddIssue( $borrower, $item_without_itemtype->{ barcode } ) } >- qr/^item-level_itypes set but no itemtype set for item/, >+ warnings_like { AddIssue( $borrower, $item_without_itemtype->{ barcode } ) } >+ [qr/^item-level_itypes set but no itemtype set for item/,qr/^item-level_itypes set but no itemtype set for item/,qr/^item-level_itypes set but no itemtype set for item/], > 'Item without itemtype set raises warning on AddIssue'; > warnings_like { AddReturn( $item_without_itemtype->{ barcode }, $branch ) } >- [qr/^item-level_itypes set but no itemtype set for item/,qr/^item-level_itypes set but no itemtype set for item/], >+ [qr/^item-level_itypes set but no itemtype set for item/,qr/^item-level_itypes set but no itemtype set for item/,qr/^item-level_itypes set but no itemtype set for item/], > 'Item without itemtype set raises warnings on AddReturn'; > #Â Test biblio-level itemtype was recorded on the 'statistics' table > $stat = $schema->resultset('Statistic')->search({ >diff --git a/t/db_dependent/Circulation/issue.t b/t/db_dependent/Circulation/issue.t >index d471d42..d1158fc 100644 >--- a/t/db_dependent/Circulation/issue.t >+++ b/t/db_dependent/Circulation/issue.t >@@ -372,6 +372,7 @@ my $itemnumber2; > homebranch => $branchcode_1, > holdingbranch => $branchcode_1, > location => 'FIC', >+ itype => $itemtype > }, > $biblionumber > ); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14576
:
46454
|
46455
|
46456
|
48258
|
48259
|
50662
|
50663
|
52195
|
52196
|
52197
|
52204
|
52205
|
52206
|
52222
|
52223
|
52224
|
52365
|
53112
|
53113
|
53114
|
53115
|
54281
|
54644
|
54645
|
54646
|
54647
|
54648
|
54654
|
55587
|
60658
|
60659
|
60660
|
60661
|
60662
|
60663
|
60747
|
60748
|
60751
|
61940
|
61941
|
61942
|
61944
|
61945
|
61946
|
61947
|
61948
|
61949
|
61950
|
64656
|
64657
|
64658
|
67610
|
67611
|
68297
|
70795
|
70796
|
70797
|
72032
|
72033
|
72034
|
75661
|
75662
|
75663
|
79245
|
79246
|
79995
|
79996
|
83113
|
83114
|
83115
|
83696
|
83697
|
83698
|
85406
|
85850
|
85851
|
85852
|
85853
|
86812
|
86813
|
86814
|
86815
|
86816
|
87040
|
87061
|
87144
|
87145
|
87146
|
87147
|
87148
|
87149
|
87150
|
87151
|
87925
|
88451
|
88452
|
88453
|
88454
|
88455
|
88456
|
88457
|
88458
|
88459
|
88646
|
88647
|
88648
|
88649
|
88650
|
88651
|
88652
|
88653
|
88654