Bugzilla – Attachment 61978 Details for
Bug 18355
Add 'permanent location' alongside 'shelving location' when located on cart
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18355: Modifies location on detail pages.
Bug-18355-Modifies-location-on-detail-pages-TEST-P.patch (text/plain), 3.11 KB, created by
Christopher Brannon
on 2017-04-07 21:00:16 UTC
(
hide
)
Description:
Bug 18355: Modifies location on detail pages.
Filename:
MIME Type:
Creator:
Christopher Brannon
Created:
2017-04-07 21:00:16 UTC
Size:
3.11 KB
patch
obsolete
>From 27d505eb34a45578ae02f1bc147978449859c58e Mon Sep 17 00:00:00 2001 >From: Christopher Brannon <cbrannon@cdalibrary.org> >Date: Fri, 7 Apr 2017 20:25:52 +0000 >Subject: [PATCH] Bug 18355: Modifies location on detail pages. TEST PLAN 1) > Make sure ReturnToShelvingCart is set to Move. 2) Check in an item. 3) View > the item in detail.pl and opac-detail.pl and see that only the cart location > shows. 4) Apply patch and view the item again in check detail.pl and > opac-detail.pl. You should now see the permanent location, and the cart > location in parenthesis. 5) Check another item that was not checked in. You > should see the permanent location and not a secondary location. > >--- > catalogue/detail.pl | 4 +++- > opac/opac-detail.pl | 7 +++++-- > 2 files changed, 8 insertions(+), 3 deletions(-) > >diff --git a/catalogue/detail.pl b/catalogue/detail.pl >index 3043661..13fe4dd 100755 >--- a/catalogue/detail.pl >+++ b/catalogue/detail.pl >@@ -242,7 +242,9 @@ foreach my $item (@items) { > #get shelf location and collection code description if they are authorised value. > # same thing for copy number > my $shelfcode = $item->{'location'}; >- $item->{'location'} = $shelflocations->{$shelfcode} if ( defined( $shelfcode ) && defined($shelflocations) && exists( $shelflocations->{$shelfcode} ) ); >+ my $permshelfcode = $item->{'permanent_location'}; >+ $item->{'location'} = $shelflocations->{$permshelfcode} if ( defined( $permshelfcode ) && defined($shelflocations) && exists( $shelflocations->{$permshelfcode} ) ); >+ $item->{'location'} .= ' (' . $shelflocations->{$shelfcode} . ')' if ( defined( $shelfcode ) && defined($shelflocations) && exists($shelflocations->{$shelfcode} ) && ($shelfcode ne $permshelfcode) ); > my $ccode = $item->{'ccode'}; > $item->{'ccode'} = $collections->{$ccode} if ( defined( $ccode ) && defined($collections) && exists( $collections->{$ccode} ) ); > my $copynumber = $item->{'copynumber'}; >diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl >index 1336ae1..212ecec 100755 >--- a/opac/opac-detail.pl >+++ b/opac/opac-detail.pl >@@ -666,8 +666,11 @@ if ( not $viewallitems and @items > $max_items_to_display ) { > $itm->{'ccode'} = $collections->{$ccode} if defined($ccode) && $collections && exists( $collections->{$ccode} ); > my $copynumber = $itm->{'copynumber'}; > $itm->{'copynumber'} = $copynumbers->{$copynumber} if ( defined($copynumbers) && defined($copynumber) && exists( $copynumbers->{$copynumber} ) ); >- if ( defined $itm->{'location'} ) { >- $itm->{'location_description'} = $shelflocations->{ $itm->{'location'} }; >+ if ( defined $itm->{'permanent_location'} ) { >+ $itm->{'location_description'} = $shelflocations->{ $itm->{'permanent_location'} }; >+ } >+ if ( ( defined $itm->{'location'} ) && ( $itm->{'location'} ne $itm->{'permanent_location'} ) ) { >+ $itm->{'location_description'} .= ' (' . $shelflocations->{ $itm->{'location'} } . ')'; > } > if (exists $itm->{itype} && defined($itm->{itype}) && exists $itemtypes->{ $itm->{itype} }) { > $itm->{'imageurl'} = getitemtypeimagelocation( 'opac', $itemtypes->{ $itm->{itype} }->{'imageurl'} ); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18355
:
61978
|
61981
|
61984
|
62999
|
66432
|
66514
|
78584
|
78908
|
78913
|
79684
|
79717
|
79786
|
80153
|
83665
|
95775
|
95879
|
95880