From 19faae8f9c55a6896acf20411e5a5402a829cb0a Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Tue, 11 Apr 2017 16:09:27 -0400 Subject: [PATCH] Bug 18367 - Fix untranslatable string from Bug 18264 Restore display of message when no barcode found To test: 1 - Go to course reserves 2 - Add an item to a course 3 - Try adding an invalid barcode - should get an alert 4 - Try force adding an item with itemnumber: http://localhost:8081/cgi-bin/koha/course_reserves/add_items.pl?op=lookpup&course_id=11&itemnumber=1234523546 5 - Should recieve an error --- course_reserves/add_items.pl | 8 +++++--- .../prog/en/modules/course_reserves/add_items-step1.tt | 4 ++-- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/course_reserves/add_items.pl b/course_reserves/add_items.pl index fc705e1..106b339 100755 --- a/course_reserves/add_items.pl +++ b/course_reserves/add_items.pl @@ -52,9 +52,11 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user( flagsrequired => { coursereserves => 'add_reserves' }, } ); -my $inumber = $itemnumber ? "(blank) (itemnumber:$itemnumber)" : ""; -$template->param( ERROR_BARCODE_NOT_FOUND => $barcode . $inumber ) - unless ( $barcode && !$itemnumber && $item && $action eq 'lookup' ); + +unless ( $item && $action eq 'lookup' ){ + $template->param( ERROR_ITEM_NOT_FOUND => 1 ); + $template->param( UNKNOWN_BARCODE => $barcode ) if $barcode; +} $template->param( course => GetCourse($course_id) ); diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/add_items-step1.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/add_items-step1.tt index b503636..1d1b036 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/add_items-step1.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/add_items-step1.tt @@ -11,8 +11,8 @@
- [% IF ERROR_BARCODE_NOT_FOUND %] -
No item found with barcode [% ERROR_BARCODE_NOT_FOUND %]
+ [% IF ERROR_ITEM_NOT_FOUND %] +
No item found [% IF UNKNOWN_BARCODE %]with barcode [% UNKNOWN_BARCODE %][% END %]
[% END %]
-- 2.1.4