From 147fcdc0f567151fd7e740ec80820833b62c2bf5 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Tue, 11 Apr 2017 07:33:32 -0300 Subject: [PATCH] Bug 18420: Use TestBuilder to create a patron category in Suggestions.t No need to do it that way, let's use TestBuilder. Test plan: prove t/db_dependent/Suggestions.t should still return green --- t/db_dependent/Suggestions.t | 19 +++++-------------- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/t/db_dependent/Suggestions.t b/t/db_dependent/Suggestions.t index 63f390e..6eb7575 100644 --- a/t/db_dependent/Suggestions.t +++ b/t/db_dependent/Suggestions.t @@ -27,6 +27,8 @@ use Koha::DateUtils qw( dt_from_string ); use Koha::Library; use Koha::Libraries; +use t::lib::TestBuilder; + use DateTime::Duration; use Test::More tests => 102; use Test::Warn; @@ -42,6 +44,7 @@ my $sql; $dbh->{AutoCommit} = 0; $dbh->{RaiseError} = 1; +my $builder = t::lib::TestBuilder->new; # Reset item types to only the default ones $dbh->do(q|DELETE FROM itemtypes;|); $sql = " @@ -67,24 +70,12 @@ if (not defined Koha::Libraries->find('CPL')) { Koha::Library->new({ branchcode => 'CPL', branchname => 'Centerville' })->store; } -my $sth = $dbh->prepare("SELECT * FROM categories WHERE categorycode='S';"); -$sth->execute(); -if (!$sth->fetchrow_hashref) { - $sql = "INSERT INTO categories - (categorycode,description,enrolmentperiod,upperagelimit, - dateofbirthrequired,finetype,bulk,enrolmentfee, - overduenoticerequired,issuelimit,reservefee,category_type) - VALUES - ('S','Staff',99,999, - 18,NULL,NULL,'0.000000', - 0,NULL,'0.000000','S');"; - $dbh->do($sql); -} +my $patron_category = $builder->build({ source => 'Category' }); my $member = { firstname => 'my firstname', surname => 'my surname', - categorycode => 'S', + categorycode => $patron_category->{categorycode}, branchcode => 'CPL', }; my $borrowernumber = AddMember(%$member); -- 2.1.4