From 0f09e575de01cb6b7e911eae7c5b7b6d09b4dd6f Mon Sep 17 00:00:00 2001
From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Date: Thu, 13 Apr 2017 13:15:30 +0200
Subject: [PATCH] Bug 18361: Additional tests for Koha::Objects->find
Content-Type: text/plain; charset=utf-8

Adding a subtest find in t/db_dependent/Koha/Objects.t.

Test plan:
Run t/db_dependent/Koha/Objects.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
---
 t/db_dependent/Koha/Objects.t | 29 ++++++++++++++++++++++++++++-
 1 file changed, 28 insertions(+), 1 deletion(-)

diff --git a/t/db_dependent/Koha/Objects.t b/t/db_dependent/Koha/Objects.t
index 935dc47..c605798 100644
--- a/t/db_dependent/Koha/Objects.t
+++ b/t/db_dependent/Koha/Objects.t
@@ -19,11 +19,12 @@
 
 use Modern::Perl;
 
-use Test::More tests => 13;
+use Test::More tests => 14;
 use Test::Warn;
 
 use Koha::Authority::Types;
 use Koha::Cities;
+use Koha::IssuingRules;
 use Koha::Patron::Category;
 use Koha::Patron::Categories;
 use Koha::Patrons;
@@ -98,6 +99,32 @@ subtest 'new' => sub {
     Koha::Patron::Categories->find($a_cat_code)->delete;
 };
 
+subtest 'find' => sub {
+    plan tests => 4;
+
+    # check find on a single PK
+    my $patron = $builder->build({ source => 'Borrower' });
+    is( Koha::Patrons->find($patron->{borrowernumber})->surname,
+        $patron->{surname}, "Checking an arbitrary patron column after find"
+    );
+    # check find with unique column
+    my $obj = Koha::Patrons->find($patron->{cardnumber}, { key => 'cardnumber' });
+    is( $obj->borrowernumber, $patron->{borrowernumber},
+        'Find with unique column and key specified' );
+    # check find with an additional where clause in the attrs hash
+    # we do not expect to find something now
+    is( Koha::Patrons->find(
+        $patron->{borrowernumber},
+        { where => { surname => { '!=', $patron->{surname} }}},
+    ), undef, 'Additional where clause in find call' );
+
+    # check find with a composite FK
+    my $rule = $builder->build({ source => 'Issuingrule' });
+    my @pk = ( $rule->{branchcode}, $rule->{categorycode}, $rule->{itemtype} );
+    is( ref(Koha::IssuingRules->find(@pk)), "Koha::IssuingRule",
+        'Find returned a Koha object for composite primary key' );
+};
+
 subtest 'search_related' => sub {
     plan tests => 8;
     my $builder   = t::lib::TestBuilder->new;
-- 
2.1.4