From de9160d780e5b86cb23fdd51e1d3706767f66a2e Mon Sep 17 00:00:00 2001 From: Alex Buckley Date: Sat, 8 Apr 2017 23:18:23 +0000 Subject: [PATCH] Bug 12930: Web installer does not show login errors MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=utf-8 Implemented invalid_username_or_password template variable being handed to Auth.tt. Removed indentation changes and modification to return value of checkpw Test plan: See comment #2 Alternative test plan: - Clear session cookies or close / open your browser - Go to [MY SERVER]/cgi-bin/koha/installer/install.pl - Verify that message appears if wrong username/pw provided - Verify that you can log in with databas administrator account Tested with alternative test plan, works as expected. Title and description in commit message adapted. Signed-off-by: Marc VĂ©ron Signed-off-by: Marcel de Rooy --- C4/InstallAuth.pm | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/C4/InstallAuth.pm b/C4/InstallAuth.pm index c91bde8..6851214 100644 --- a/C4/InstallAuth.pm +++ b/C4/InstallAuth.pm @@ -379,6 +379,10 @@ sub checkauth { $template->param( login => 1 ); $template->param( loginprompt => 1 ) unless $info{'nopermission'}; + if ($info{'invalid_username_or_password'} == 1) { + $template->param( 'invalid_username_or_password' => $info{'invalid_username_or_password'}); + } + $template->param( \%info ); $cookie = $query->cookie( -name => 'CGISESSID', -- 2.1.4