Bugzilla – Attachment 62194 Details for
Bug 2454
Improve display of credits on pay fines tab
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 2454 - Removed the display of accountype, Notify ID, Level values for manual credit in pay.tt and replaced the description with string "Credit"
Bug-2454---Removed-the-display-of-accountype-Notif.patch (text/plain), 5.83 KB, created by
Alex Buckley
on 2017-04-17 05:27:15 UTC
(
hide
)
Description:
Bug 2454 - Removed the display of accountype, Notify ID, Level values for manual credit in pay.tt and replaced the description with string "Credit"
Filename:
MIME Type:
Creator:
Alex Buckley
Created:
2017-04-17 05:27:15 UTC
Size:
5.83 KB
patch
obsolete
>From bf58c1b21d7f3678022e15c099896a6fcbb32ab1 Mon Sep 17 00:00:00 2001 >From: Alex Buckley <alexbuckley@catalyst.net.nz> >Date: Mon, 17 Apr 2017 05:04:51 +0000 >Subject: [PATCH] Bug 2454 - Removed the display of accountype, Notify ID, > Level values for manual credit in pay.tt and replaced the description with > string "Credit" > >These specific values have been removed because this bug report requires >the manual credit to no longer be shown on the 'Pay fines' tab. > >In response to comment 4 (thankyou for noticing that Felix) I have redone this patch so users can now successfully pay or write off manual credits because the >manual credit values although not being displayed are still being >submitted to pay.pl. > >Test plan: >1. From the Koha staff interface go the Patron area and select a patron >page > >2. Create a fine of $10 for the patron by clicking on the 'Fines' tab and >creating a fine in the 'Create manual invoice' tab > >3. Create a credit of $5 for the patron in the 'Create manual credit' >page > >4. Then go to the 'Pay fines' tab and notice there is a row for both the fine and >credit both with values in the account type, Notify ID, and level boxes >of the table > >5. Select "write off all" and 'OK' in the confirmation box > >6. Youre redirected to Account tab, return to 'pay fines' tab and notice no >fines or credits are displayed > >7. Repeat steps 2, 3, 4 and then click "Pay amount", confirm it, then navigate back >to the 'Pay fines' tab and notice although the fine and credit are >displayed the 'total due' value is 0.00 > >8. Apply the patch attached to this bug report > >9. Repeat steps 2, and 3. > >10. Navigate to 'Pay fines' tab and notice the fine has values >in account type, Notify ID, and level and the credit does not. Additionally >credit has the description value of 'Credit' > >11. Repeat steps 5 and 6 and as with before this patch was applied >notice the 'Pay fines' tab does not show any fines or credits > >12. Repeat step 7 and again notice the 'Total due' value is 0.00 >--- > .../intranet-tmpl/prog/en/modules/members/pay.tt | 68 +++++++++++++--------- > 1 file changed, 40 insertions(+), 28 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt >index 092cc0d..688b149 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt >@@ -101,6 +101,7 @@ function enableCheckboxActions(){ > [% END %] > </td> > <td> >+ > [% IF ( line.amountoutstanding > 0 ) %] > <input type="submit" name="pay_indiv_[% line.accountlines_id %]" value="Pay" /> > [% IF CAN_user_updatecharges_writeoff %]<input type="submit" name="wo_indiv_[% line.accountlines_id %]" value="Write off" />[% END %] >@@ -117,35 +118,46 @@ function enableCheckboxActions(){ > <input type="hidden" name="totals[% line.accountlines_id %]" value="[% line.totals %]" /> > </td> > <td> >- [% SWITCH line.accounttype %] >- [% CASE 'Pay' %]Payment, thanks >- [% CASE 'Pay00' %]Payment, thanks (cash via SIP2) >- [% CASE 'Pay01' %]Payment, thanks (VISA via SIP2) >- [% CASE 'Pay02' %]Payment, thanks (credit card via SIP2) >- [% CASE 'N' %]New card >- [% CASE 'F' %]Fine >- [% CASE 'A' %]Account management fee >- [% CASE 'M' %]Sundry >- [% CASE 'L' %]Lost item >- [% CASE 'W' %]Writeoff >- [% CASE 'FU' %]Accruing fine >- [% CASE 'HE' %]Hold waiting too long >- [% CASE 'Rent' %]Rental fee >- [% CASE 'FOR' %]Forgiven >- [% CASE 'LR' %]Lost item fee refund >- [% CASE 'PAY' %]Payment >- [% CASE 'WO' %]Writeoff >- [% CASE 'C' %]Credit >- [% CASE 'CR' %]Credit >- [% CASE %][% line.accounttype %] >- [%- END -%] >- [%- IF line.description %], [% line.description %][% END %] >- [% IF line.title %]([% line.title %])[% END %] >+ [% IF (line.amountoutstanding > 0) %] >+ [% SWITCH line.accounttype %] >+ [% CASE 'Pay' %]Payment, thanks >+ [% CASE 'Pay00' %]Payment, thanks (cash via SIP2) >+ [% CASE 'Pay01' %]Payment, thanks (VISA via SIP2) >+ [% CASE 'Pay02' %]Payment, thanks (credit card via SIP2) >+ [% CASE 'N' %]New card >+ [% CASE 'F' %]Fine >+ [% CASE 'A' %]Account management fee >+ [% CASE 'M' %]Sundry >+ [% CASE 'L' %]Lost item >+ [% CASE 'W' %]Writeoff >+ [% CASE 'FU' %]Accruing fine >+ [% CASE 'HE' %]Hold waiting too long >+ [% CASE 'Rent' %]Rental fee >+ [% CASE 'FOR' %]Forgiven >+ [% CASE 'LR' %]Lost item fee refund >+ [% CASE 'PAY' %]Payment >+ [% CASE 'WO' %]Writeoff >+ [% CASE 'C' %]Credit >+ [% CASE 'CR' %]Credit >+ [% CASE %][% line.accounttype %] >+ [%- END -%] >+ [%- IF line.description %], [% line.description %][% END %] >+ [% IF line.title %]([% line.title %])[% END %] >+ [% ELSE %] >+ Credit >+ [% END %] > </td> >- <td><input type="text" name="payment_note_[% line.accountlines_id %]" /></td> >- <td>[% line.accounttype %]</td> >- <td>[% line.notify_id %]</td> >- <td>[% line.notify_level %]</td> >+ [% IF (line.amountoutstanding > 0) %] >+ <td><input type="text" name="payment_note_[% line.accountlines_id %]" /></td> >+ <td>[% line.accounttype %]</td> >+ <td>[% line.notify_id %]</td> >+ <td>[% line.notify_level %]</td> >+ [% ELSE %] >+ <td></td> >+ <td></td> >+ <td></td> >+ <td></td> >+ [% END %] > <td class="debit" style="text-align: right;">[% line.amount | $Price %]</td> > <td class="debit" style="text-align: right;">[% line.amountoutstanding | $Price %]</td> > </tr> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 2454
:
672
|
673
|
61764
|
61765
|
62194
|
62953
|
62991
|
62994
|
68470
|
69098
|
69210