View | Details | Raw Unified | Return to bug 18433
Collapse All | Expand All

(-)a/Koha/AuthorisedValueCategories.pm (-3 / +3 lines)
Lines 36-50 Koha::AuthorisedValueCategories - Koha AuthorisedValueCategory Object set class Link Here
36
36
37
=cut
37
=cut
38
38
39
=head3 findByKohaField
39
=head3 find_by_koha_field
40
40
41
    my $category = Koha::AuthorisedValueCategories->findByKohaField($kohafield, [$frameworkcode]);
41
    my $category = Koha::AuthorisedValueCategories->find_by_koha_field($kohafield, [$frameworkcode]);
42
42
43
Returns the authorised value category linked to the given koha field
43
Returns the authorised value category linked to the given koha field
44
44
45
=cut
45
=cut
46
46
47
sub findByKohaField {
47
sub find_by_koha_field {
48
    my ($class, $kohafield, $frameworkcode) = @_;
48
    my ($class, $kohafield, $frameworkcode) = @_;
49
49
50
    $frameworkcode //= '';
50
    $frameworkcode //= '';
(-)a/Koha/Template/Plugin/AuthorisedValues.pm (-1 / +1 lines)
Lines 72-78 sub GetCategories { Link Here
72
sub GetCategoryByKohaField {
72
sub GetCategoryByKohaField {
73
    my ($self, $kohafield, $frameworkcode) = @_;
73
    my ($self, $kohafield, $frameworkcode) = @_;
74
74
75
    my $category = Koha::AuthorisedValueCategories->findByKohaField($kohafield, $frameworkcode);
75
    my $category = Koha::AuthorisedValueCategories->find_by_koha_field($kohafield, $frameworkcode);
76
76
77
    return $category ? $category->category_name : undef;
77
    return $category ? $category->category_name : undef;
78
}
78
}
(-)a/catalogue/item-export.pl (-7 / +1 lines)
Lines 37-49 my ($template, $borrowernumber, $cookie) = get_template_and_user({ Link Here
37
my @itemnumbers = $cgi->multi_param('itemnumber');
37
my @itemnumbers = $cgi->multi_param('itemnumber');
38
my $format = $cgi->param('format') // 'csv';
38
my $format = $cgi->param('format') // 'csv';
39
39
40
my @items;
40
my @items = Koha::Items->search({ itemnumber => { -in => \@itemnumbers } });
41
foreach my $itemnumber (@itemnumbers) {
42
    my $item = Koha::Items->find($itemnumber);
43
    if ($item) {
44
        push @items, $item;
45
    }
46
}
47
41
48
if ($format eq 'barcodes') {
42
if ($format eq 'barcodes') {
49
    print $cgi->header({
43
    print $cgi->header({
(-)a/catalogue/itemsearch.pl (-1 / +1 lines)
Lines 247-253 foreach my $itemtype ( Koha::ItemTypes->search ) { Link Here
247
    };
247
    };
248
}
248
}
249
249
250
my $ccode_avcategory = Koha::AuthorisedValueCategories->findByKohaField('items.ccode');
250
my $ccode_avcategory = Koha::AuthorisedValueCategories->find_by_koha_field('items.ccode');
251
my $ccode_avcode = $ccode_avcategory ? $ccode_avcategory->category_name : 'CCODE';
251
my $ccode_avcode = $ccode_avcategory ? $ccode_avcategory->category_name : 'CCODE';
252
my $ccodes = GetAuthorisedValues($ccode_avcode);
252
my $ccodes = GetAuthorisedValues($ccode_avcode);
253
my @ccodes;
253
my @ccodes;
(-)a/t/db_dependent/Koha/AuthorisedValueCategories.t (-1 / +59 lines)
Line 0 Link Here
0
- 
1
#!/usr/bin/perl
2
3
# Copyright 2017 BibLibre
4
#
5
# This file is part of Koha
6
#
7
# Koha is free software; you can redistribute it and/or modify it
8
# under the terms of the GNU General Public License as published by
9
# the Free Software Foundation; either version 3 of the License, or
10
# (at your option) any later version.
11
#
12
# Koha is distributed in the hope that it will be useful, but
13
# WITHOUT ANY WARRANTY; without even the implied warranty of
14
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15
# GNU General Public License for more details.
16
#
17
# You should have received a copy of the GNU General Public License
18
# along with Koha; if not, see <http://www.gnu.org/licenses>.
19
20
use Modern::Perl;
21
22
use Test::More tests => 3;
23
24
use Koha::MarcSubfieldStructures;
25
use Koha::Database;
26
27
use t::lib::TestBuilder;
28
29
BEGIN {
30
    use_ok('Koha::AuthorisedValueCategories');
31
}
32
33
my $schema = Koha::Database->new->schema;
34
$schema->storage->txn_begin;
35
36
my $category = Koha::AuthorisedValueCategories->find_or_create({
37
    category_name => 'TEST',
38
});
39
40
Koha::MarcSubfieldStructures->search({
41
    frameworkcode => '',
42
    kohafield => 'items.notforloan',
43
})->delete();
44
45
my $subfield = Koha::MarcSubfieldStructures->find_or_create({
46
    frameworkcode => '',
47
    tagfield => 999,
48
    tagsubfield => 9,
49
});
50
$subfield->authorised_value($category->category_name)
51
    ->kohafield('items.notforloan')
52
    ->store();
53
54
my $result = Koha::AuthorisedValueCategories->find_by_koha_field('items.notforloan');
55
56
isa_ok($result, 'Koha::AuthorisedValueCategory', 'Result found');
57
is($result->category_name, $category->category_name, 'Result is correct');
58
59
$schema->storage->txn_rollback;

Return to bug 18433