Bugzilla – Attachment 62582 Details for
Bug 13835
Popup with searches: results hidden by language menu in footer
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13835: Popup with searches: results hidden by language menu in footer
Bug-13835-Popup-with-searches-results-hidden-by-la.patch (text/plain), 2.84 KB, created by
Alex Buckley
on 2017-04-24 00:05:11 UTC
(
hide
)
Description:
Bug 13835: Popup with searches: results hidden by language menu in footer
Filename:
MIME Type:
Creator:
Alex Buckley
Created:
2017-04-24 00:05:11 UTC
Size:
2.84 KB
patch
obsolete
>From 83a0299a11923f1d22223f170ea35e671ee6ff89 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch> >Date: Fri, 21 Apr 2017 21:22:44 +0200 >Subject: [PATCH] Bug 13835: Popup with searches: results hidden by language > menu in footer > >Language menus in pop up windows are not necessary and can hide the contents >(especially search results) on a narrow screen. > >For an example, see screenshot in comment #3 > >This patch allows to mark pop p menus not to display the language footer. > >To test: > >- Reproduce issue from comment #3 >- Apply patch >- Try to reproduce issue from comment #3 > -> language menu should no longer display >- Verify that language menu is suppresed in 'Add to ist' as well > (from catalog search results, select an item, Add to:...) > >Note: There will be more pop-ups with unwnated language selector. > That can be resolved in follow up bugs. > >Followed test plan which worked as intended >Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/common/patron_search.tt | 1 + > .../intranet-tmpl/prog/en/modules/virtualshelves/addbybiblionumber.tt | 2 +- > 3 files changed, 3 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc >index 4d59da1..fb6ffbb 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc >@@ -1,6 +1,6 @@ > </div> > >-[% IF ( languages_loop ) %] >+[% IF ( languages_loop && ! popup_window ) %] > [% UNLESS ( one_language_enabled ) %] > <div id="changelanguage" class="navbar navbar-default navbar-fixed-bottom"> > <div class="container-fluid"> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/common/patron_search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/common/patron_search.tt >index 8b52cac..9fe6473 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/common/patron_search.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/common/patron_search.tt >@@ -252,4 +252,5 @@ function filterByFirstLetterSurname(letter) { > <div id="closewindow"><a href="#" class="btn btn-default btn-default close">Close</a></div> > </div> > </div> >+[% SET popup_window = 1 %] > [% INCLUDE 'intranet-bottom.inc' %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/addbybiblionumber.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/addbybiblionumber.tt >index 63974a9..3635a7a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/addbybiblionumber.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/addbybiblionumber.tt >@@ -114,6 +114,6 @@ > <!-- /SAVE --> > > </div> >- >+[% SET popup_window = 1 %] > [% INCLUDE 'intranet-bottom.inc' %] > [% END %] >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13835
:
62557
|
62558
|
62559
|
62582
|
62626