Bugzilla – Attachment 62802 Details for
Bug 3311
Statistical reports should error if row and column aren't selected
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 3311: Issues stat report HTML clean up.
Bug-3311-Issues-stat-report-HTML-clean-up.patch (text/plain), 7.17 KB, created by
Mark Tompsett
on 2017-04-27 18:39:43 UTC
(
hide
)
Description:
Bug 3311: Issues stat report HTML clean up.
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2017-04-27 18:39:43 UTC
Size:
7.17 KB
patch
obsolete
>From 5e2eb0c9a8b527c6749ef75bb24efcdf41d8e3db Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Thu, 27 Apr 2017 13:53:08 -0400 >Subject: [PATCH] Bug 3311: Issues stat report HTML clean up. > >--- > .../prog/en/modules/reports/issues_stats.tt | 26 +++++++++++----------- > 1 file changed, 13 insertions(+), 13 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt >index 3ebfac8..e990dc1 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt >@@ -128,7 +128,7 @@ > </td> > <td> > <label for="PeriodDaySel">Select day: </label><select name="PeriodDaySel" id="PeriodDaySel"> >- <option value =""></option> >+ <option value ="">Any day</option> > <option value ="Monday">Monday</option> > <option value ="Tuesday">Tuesday</option> > <option value ="Wednesday">Wednesday</option> >@@ -138,7 +138,7 @@ > <option value ="Sunday">Sunday</option> > </select> > <label for="PeriodMonthSel">Select month:</label> <select name="PeriodMonthSel" id="PeriodMonthSel"> >- <option value =""></option> >+ <option value ="">Any month</option> > <option value ="January">January</option> > <option value ="February">February</option> > <option value ="March">March</option> >@@ -159,7 +159,7 @@ > <td><input type="radio" name="Line" value="borrowers.categorycode" /></td> > <td><input type="radio" name="Column" value="borrowers.categorycode" /></td> > <td><select name="Filter" id="borcat"> >- <option value=""> </option> >+ <option value="">Not filtered by category</option> > [% FOREACH categoryloo IN categoryloop %] > <option value="[% categoryloo.categorycode %]">[% categoryloo.description %]</option> > [% END %] >@@ -171,7 +171,7 @@ > <td><input type="radio" name="Line" value="itemtype" /></td> > <td><input type="radio" name="Column" value="itemtype" /></td> > <td><select name="Filter" id="itemtype"> >- <option value=""> </option> >+ <option value="">Not filtered by item type</option> > [% FOREACH itemtype IN itemtypes %] > <option value="[% itemtype.itemtype %]">[% itemtype.translated_description %]</option> > [% END %] >@@ -183,7 +183,7 @@ > <td><input type="radio" name="Line" value="branch" /></td> > <td><input type="radio" name="Column" value="branch" /></td> > <td><select name="Filter" id="branch"> >- <option value=""> </option> >+ <option value="">Not filtered by issuing library</option> > [% PROCESS options_for_libraries libraries => Branches.all() %] > </select> > </td> >@@ -193,7 +193,7 @@ > <td><input type="radio" name="Line" value="items.ccode" /></td> > <td><input type="radio" name="Column" value="items.ccode" /></td> > <td><select name="Filter" id="ccode"> >- <option value=""> </option> >+ <option value="">Not filtered by collection</option> > [% FOREACH ccodeloo IN ccodeloop %] > <option value="[% ccodeloo.code %]">[% ccodeloo.description %]</option> > [% END %] >@@ -205,7 +205,7 @@ > <td><input type="radio" name="Line" value="items.location" /></td> > <td><input type="radio" name="Column" value="items.location" /></td> > <td><select name="Filter" id="location"> >- <option value=""> </option> >+ <option value="">Not filtered by shelving location</option> > [% FOREACH locationloo IN locationloop %] > <option value="[% locationloo.code %]">[% locationloo.description %]</option> > [% END %] >@@ -223,7 +223,7 @@ > <td><input type="radio" name="Line" value="borrowers.sort1" /></td> > <td><input type="radio" name="Column" value="borrowers.sort1" /></td> > <td><select name="Filter" id="sort1"> >- <option value=""> </option> >+ <option value="">Not filtered by Sort1</option> > [% FOREACH Bsort IN Bsort1 %] > <option value="[% Bsort.authorised_value %]" >[% Bsort.lib %]</option> > [% END %] >@@ -236,7 +236,7 @@ > <td><input type="radio" name="Line" value="borrowers.sort2" /></td> > <td><input type="radio" name="Column" value="borrowers.sort2" /></td> > <td><select name="Filter" id="sort2"> >- <option value=""> </option> >+ <option value="">Not filtered by Sort2</option> > [% FOREACH Bsort IN Bsort2 %] > <option value="[% Bsort.authorised_value %]" >[% Bsort.lib %]</option> > [% END %] >@@ -248,7 +248,7 @@ > <td><input type="radio" name="Line" value="items.homebranch" /></td> > <td><input type="radio" name="Column" value="items.homebranch" /></td> > <td><select name="Filter" id="homebranch"> >- <option value=""> </option> >+ <option value="">Not filtered by home library</option> > [% PROCESS options_for_libraries libraries => Branches.all() %] > </select> > </td> >@@ -258,7 +258,7 @@ > <td><input type="radio" name="Line" value="items.holdingbranch" /></td> > <td><input type="radio" name="Column" value="items.holdingbranch" /></td> > <td><select name="Filter" id="holdingbranch"> >- <option value=""> </option> >+ <option value="">Not filtered by holding library</option> > [% PROCESS options_for_libraries libraries => Branches.all() %] > </select> > </td> >@@ -269,7 +269,7 @@ > <td><input type="radio" name="Column" value="borrowers.branchcode" /></td> > <td> > <select name="Filter" id="patronbranch"> >- <option value=""> </option> >+ <option value="">Not filtered by patron's library</option> > [% FOREACH branch IN branchloop %] > <option value="[% branch.value %]"> > [% branch.branchname %] >@@ -297,7 +297,7 @@ > <td> > [% IF attr_type.authorised_value_category %] > <select name="Filter_borrower_attributes.[% attr_type.code %]"> >- <option value=""> </option> >+ <option value="">Not filtered</option> > [% FOREACH av IN attr_type.authorised_values %] > <option value="[% av.authorised_value %]"> > [% av.lib %] >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 3311
:
52775
|
52776
|
52777
|
52778
|
52779
|
53194
|
53195
|
53291
|
62533
|
62541
|
62623
|
62624
|
62630
|
62658
|
62659
|
62776
|
62777
|
62793
|
62794
|
62795
|
62796
|
62797
|
62798
|
62799
|
62800
|
62801
| 62802