Bugzilla – Attachment 62906 Details for
Bug 18291
Remove SQL from preferences.pl administrative script
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18291 - Implemented call to C4::Context->preference($name) in admin/preferences.pl which uses cached preference values
Bug-18291---Implemented-call-to-C4Context-preferen.patch (text/plain), 1.49 KB, created by
Alex Buckley
on 2017-05-01 09:52:55 UTC
(
hide
)
Description:
Bug 18291 - Implemented call to C4::Context->preference($name) in admin/preferences.pl which uses cached preference values
Filename:
MIME Type:
Creator:
Alex Buckley
Created:
2017-05-01 09:52:55 UTC
Size:
1.49 KB
patch
obsolete
>From 9eac0b4811e7f3212cbc1175837ebb7b4fe6e8aa Mon Sep 17 00:00:00 2001 >From: Alex Buckley <alexbuckley@catalyst.net.nz> >Date: Mon, 1 May 2017 08:58:49 +0000 >Subject: [PATCH] Bug 18291 - Implemented call to > C4::Context->preference($name) in admin/preferences.pl which uses cached > preference values > >--- > admin/preferences.pl | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/admin/preferences.pl b/admin/preferences.pl >index 032789f..c16b933 100755 >--- a/admin/preferences.pl >+++ b/admin/preferences.pl >@@ -158,12 +158,12 @@ sub TransformPrefsToHTML { > my $name = $piece->{'pref'}; > > if ( $name ) { >- my $row = $dbh->selectrow_hashref( "SELECT value, type FROM systempreferences WHERE variable = ?", {}, $name ); >+ my $row = C4::Context->preference($name); > my $value; >- if ( ( !defined( $row ) || ( !defined( $row->{'value'} ) && $row->{'type'} ne 'YesNo' ) ) && defined( $piece->{'default'} ) ) { >+ if ( ( !defined( $row ) || ( !defined( $piece->{'value'} ) && $piece->{'type'} ne 'YesNo' ) ) && defined( $piece->{'default'} ) ) { > $value = $piece->{'default'}; > } else { >- $value = $row->{'value'}; >+ $value = $piece->{'value'}; > } > my $chunk = _get_chunk( $value, %$piece ); > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18291
:
61235
|
61236
|
62517
|
62518
|
62905
| 62906