From 0a492e73f8303c4efc1e9c3aa078da8800726c3d Mon Sep 17 00:00:00 2001 From: Christopher Brannon Date: Tue, 2 May 2017 20:20:14 +0000 Subject: [PATCH] Bug 18503: Fixes confusing dialog and other minor This corrects the returns2 dialog logic, and cleans up a few pieces of code. Patch also updates some buttons and fixes check in layout. To Test: 1) Check out an item. 2) Check item in. Note old buttons (Submit next to barcode, Clear). Note message next to calendar is wrapping to next line. Note Clear button is next to the check box rather than next to the calendar. 3) Check in item at a different branch both with AllowReturnToBranch in all four settings and with AutomaticItemReturn set to Do and Don't. Note old style buttons on all dialogs. 4) Place a hold on an item for pickup at another library. 5) Trigger the hold and confirm. 6) Check in item at another library (not the pickup location). 7) Note the confusing transfer/hold buttons and message. 8) Apply patch 9) Repeat steps 1-8. Note changes to the items pointed out in those steps. --- .../intranet-tmpl/prog/en/modules/circ/returns.tt | 129 +++++++++++++-------- 1 file changed, 78 insertions(+), 51 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt index 72739d1..fe3c275 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt @@ -181,17 +181,17 @@ $(document).ready(function () { [% END %] -[% IF ( collectionItemNeedsTransferred ) %] +[% IF collectionItemNeedsTransferred %]

Transferring item to: [% Branches.GetName( collectionBranch ) %]

[% itembarcode |html %]: [% title |html %]

This item is part of a rotating collection.

-

+

[% END %] -[% IF ( fines ) %] +[% IF fines %]

Patron has outstanding fines of [% fines %].

Make payment.

@@ -199,7 +199,7 @@ $(document).ready(function () { [% END %] -[% IF ( waiting_holds ) %] +[% IF waiting_holds %]

[% holdsfirstname %] [% holdssurname %] has [% waiting_holds %] hold(s) waiting for pickup.

Check out to this patron.

@@ -218,47 +218,68 @@ $(document).ready(function () {
[% END %] -[% IF ( wrongbranch ) %] +[% IF wrongbranch %]

Cannot check in

[% itembarcode |html %]: [% title |html %]

NOT CHECKED IN

This item must be checked in at following library: [% Branches.GetName( rightbranch ) %]

[% END %] - -[% IF ( WrongTransfer ) %] -
- -

Transferring item to: [% Branches.GetName( TransferWaitingAt ) %]

-

[% itembarcode |html %]: [% title |html %]

- - - [% IF ( wborcnum ) %]
Hold for:
- -
- - - - - - - - - - -
- [% END %] -
+ +[% IF WrongTransfer %] + [% IF !wborcnum %] + +
+

Transfer in progress to:
+ [% Branches.GetName( TransferWaitingAt ) %]

+

[% itembarcode |html %]: [% title |html %]

+ + +
+ [% ELSIF wborcnum %] + + + [% END %] [% END %] [% IF ( found ) %] @@ -374,11 +395,11 @@ $(document).ready(function () { [% END %]
- + - + [% FOREACH inputloo IN inputloop %] @@ -396,26 +417,31 @@ $(document).ready(function () {
[% END %] - [% IF ( transfer ) %] + [% IF transfer || ( WrongTransfer && !wborcnum ) %]

Transferring item to: [% Branches.GetName( returnbranch ) %]

[% itembarcode |html %]: [% title |html %]

- - + +
[% END %] - [% IF ( needstransfer ) %] + [% IF needstransfer %] -

This item needs to be transferred to [% Branches.GetName( returnbranch ) %]

- Transfer now?
+
+

This item needs to be transferred to +
+ [% Branches.GetName( returnbranch ) %] +

+ Transfer now?
+

[% IF itemnumber %] - + [% END %] - - + + @@ -671,19 +697,20 @@ $(document).ready(function () { [% ELSE %] [% END %] - + [% IF Koha.Preference('SpecifyReturnDate') %]
Specify return date [% INCLUDE 'date-format.inc' %]:
+ +
[% IF ( return_date_override_remember ) %] [% ELSE %] [% END %] -
[% END %] [% FOREACH inputloo IN inputloop %] -- 2.1.4