From 32c77a17d59d98591fe7e20e9dc8e4f3abd1754c Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Tue, 17 Jan 2017 16:49:40 +0100 Subject: [PATCH] Bug 17925: Disable debugging in reports/bor_issues_top.pl Remove setting $debug to 1. This prevents creation of file tmp/bor_issues_top.debug.log. Enable warnings pragma. Resolve a uninitialized warning on $sep like: Use of uninitialized value $CGI::Compile::ROOT::usr_share_koha_masterclone_reports_bor_issues_top_2epl::sep in string eq at /usr/share/koha/masterclone/reports/bor_issues_top.pl line 66. Test plan: Restart Plack (as you always do when testing). Remove file /tmp/bor_issues_top.debug.log. Open Reports/Patrons with the most checkouts. Check if the file in /tmp has not been created again. Check the log for warnings after you restarted Plack. Signed-off-by: Marcel de Rooy Signed-off-by: Mason James Signed-off-by: Jonathan Druart --- reports/bor_issues_top.pl | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/reports/bor_issues_top.pl b/reports/bor_issues_top.pl index d4d4dbe..84a46a3 100755 --- a/reports/bor_issues_top.pl +++ b/reports/bor_issues_top.pl @@ -17,8 +17,8 @@ # You should have received a copy of the GNU General Public License # along with Koha; if not, see . -use strict; -#use warnings; FIXME - Bug 2505 +use Modern::Perl; + use CGI qw ( -utf8 ); use C4::Auth; use C4::Output; @@ -41,7 +41,6 @@ plugin that shows a stats on borrowers =cut -$debug = 1; $debug and open DEBUG, ">/tmp/bor_issues_top.debug.log"; my $input = new CGI; @@ -63,7 +62,7 @@ my ($template, $borrowernumber, $cookie) flagsrequired => {reports => '*'}, debug => 1, }); -our $sep = $input->param("sep"); +our $sep = $input->param("sep") || C4::Context->preference('delimiter') || ','; $sep = "\t" if ($sep eq 'tabulation'); $template->param(do_it => $do_it, ); -- 2.1.4