From 58ee69bfdfda0aa83fb27eda623d951deb5cd495 Mon Sep 17 00:00:00 2001 From: Julian Maurice Date: Fri, 12 May 2017 09:25:23 +0200 Subject: [PATCH] Bug 18579: Fix call to append_fields, fix tests Content-Type: text/plain; charset=utf-8 MARC::Record::append_fields takes a list of MARC::Field (not an arrayref) Use $record->subfield() instead of $record->field()->subfield() to avoid errors when field doesn't exist Signed-off-by: Marcel de Rooy --- Koha/Filter/MARC/EmbedItemsAvailability.pm | 2 +- t/db_dependent/Koha/Filter/EmbedItemsAvailability.t | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Koha/Filter/MARC/EmbedItemsAvailability.pm b/Koha/Filter/MARC/EmbedItemsAvailability.pm index e42ba02..fed3aa2 100644 --- a/Koha/Filter/MARC/EmbedItemsAvailability.pm +++ b/Koha/Filter/MARC/EmbedItemsAvailability.pm @@ -90,7 +90,7 @@ sub _processrecord { else { # no field, create one $destination_field = MARC::Field->new( '999', '', '', x => $not_onloan_items ); - $record->append_fields([$destination_field]); + $record->append_fields($destination_field); } return $record; diff --git a/t/db_dependent/Koha/Filter/EmbedItemsAvailability.t b/t/db_dependent/Koha/Filter/EmbedItemsAvailability.t index 74a8d03e..8f250dd 100755 --- a/t/db_dependent/Koha/Filter/EmbedItemsAvailability.t +++ b/t/db_dependent/Koha/Filter/EmbedItemsAvailability.t @@ -142,10 +142,10 @@ subtest 'EmbedItemsAvailability tests' => sub { is( ref($processor), 'Koha::RecordProcessor', 'Created record processor' ); $record = GetMarcBiblio($biblionumber); - ok( !defined $record->field('999')->subfield('x'), q{The record doesn't originally contain 999$x} ); + ok( !defined $record->subfield('999', 'x'), q{The record doesn't originally contain 999$x} ); # Apply filter $processor->process($record); - is($record->field('999')->subfield('x'), 1, 'There is only one item with undef onloan'); + is($record->subfield('999', 'x'), 1, 'There is only one item with undef onloan'); $schema->storage->txn_rollback(); }; -- 2.1.4