Bugzilla – Attachment 63422 Details for
Bug 18582
Hide empty rows in detailed suggestion view
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 18582 - Hide empty rows in detailed suggestion view
SIGNED-OFF-Bug-18582---Hide-empty-rows-in-detailed.patch (text/plain), 4.38 KB, created by
Josef Moravec
on 2017-05-12 10:28:40 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 18582 - Hide empty rows in detailed suggestion view
Filename:
MIME Type:
Creator:
Josef Moravec
Created:
2017-05-12 10:28:40 UTC
Size:
4.38 KB
patch
obsolete
>From 2f019cc99a2014ab70969beaa4270b74ab6fdd23 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 11 May 2017 16:45:42 +0000 >Subject: [PATCH] [SIGNED-OFF] Bug 18582 - Hide empty rows in detailed > suggestion view > >This patch adds a check for the existence of various template variables >before showing the row containing that data. This will prevent the >display of rows containing labels but no data in the suggestions >detailed view. > >To test, apply the patch and go to Acquisitions -> Suggestions. > >View the detail page of various suggestions and confirm that only fields >with data are displaying. > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >--- > .../prog/en/modules/suggestion/suggestion.tt | 65 ++++++++++++++++++---- > 1 file changed, 54 insertions(+), 11 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >index 62335e8..85b0821 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >@@ -210,16 +210,54 @@ h4.local_collapse a { font-size : 80%; text-decoration: none; } fieldset.brief o > <fieldset class="rows"> > <legend>Bibliographic information</legend> > <ol> >- <li><span class="label">Title:</span>[% title |html %]</li> >- <li><span class="label">Author:</span>[% author |html %]</li> >- <li><span class="label">Copyright date:</span>[% copyrightdate |html %]</li> >- <li><span class="label">ISBN or ISSN or other standard number:</span>[% isbn |html %]</li> >- <li><span class="label">Publisher:</span>[% publishercode |html %]</li> >- <li><span class="label">Publication place:</span>[% place |html %]</li> >- <li><span class="label">Collection title:</span>[% collectiontitle |html %]</li> >- <li><span class="label">Document type:</span> >- [% AuthorisedValues.GetByCode( 'SUGGEST_FORMAT', itemtype, 0 ) %] >- </li> >+ [% IF ( title ) %] >+ <li> >+ <span class="label">Title:</span> >+ [% title |html %] >+ </li> >+ [% END %] >+ [% IF ( author ) %] >+ <li> >+ <span class="label">Author:</span> >+ [% author |html %] >+ </li> >+ [% END %] >+ [% IF ( copyrightdate ) %] >+ <li> >+ <span class="label">Copyright date:</span> >+ [% copyrightdate |html %] >+ </li> >+ [% END %] >+ [% IF ( isbn ) %] >+ <li> >+ <span class="label">ISBN or ISSN or other standard number:</span> >+ [% isbn |html %] >+ </li> >+ [% END %] >+ [% IF ( publishercode ) %] >+ <li> >+ <span class="label">Publisher:</span> >+ [% publishercode |html %] >+ </li> >+ [% END %] >+ [% IF ( place ) %] >+ <li> >+ <span class="label">Publication place:</span> >+ [% place |html %] >+ </li> >+ [% END %] >+ [% IF ( collectiontitle ) %] >+ <li> >+ <span class="label">Collection title:</span> >+ [% collectiontitle |html %] >+ </li> >+ [% END %] >+ [% IF ( itemtype ) %] >+ <li> >+ <span class="label">Document type:</span> >+ [% AuthorisedValues.GetByCode( 'SUGGEST_FORMAT', itemtype, 0 ) %] >+ </li> >+ [% END %] > [% IF ( patron_reason_loop ) %] > <li><span class="label">Reason for suggestion: </span> > [% FOREACH patron_reason_loo IN patron_reason_loop %] >@@ -227,7 +265,12 @@ h4.local_collapse a { font-size : 80%; text-decoration: none; } fieldset.brief o > [% END %] > </li> > [% END %] >- <li><span class="label">Notes:</span>[% note |html %]</li> >+ [% IF ( note ) %] >+ <li> >+ <span class="label">Notes:</span> >+ [% note |html %] >+ </li> >+ [% END %] > </ol> > </fieldset> > <fieldset class="rows"> <legend>Suggestion management</legend> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18582
:
63391
|
63422
|
64419