Bugzilla – Attachment 63533 Details for
Bug 18625
Update borrower last seen from SIP
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
proposed patch
0001-Bug-18625-update-lastseen-in-patron-info-request.patch (text/plain), 1.71 KB, created by
Colin Campbell
on 2017-05-18 15:28:31 UTC
(
hide
)
Description:
proposed patch
Filename:
MIME Type:
Creator:
Colin Campbell
Created:
2017-05-18 15:28:31 UTC
Size:
1.71 KB
patch
obsolete
>From c26e3f4534cebb136cd85399792d8accffca7748 Mon Sep 17 00:00:00 2001 >From: Colin Campbell <colin.campbell@ptfs-europe.com> >Date: Thu, 18 May 2017 15:59:49 +0100 >Subject: [PATCH] Bug 18625 update lastseen in patron info request > >Many services use SIP patron req info to validate a patron against >the koha database. If recording lastseen sites will >also want to record that the user has accessed these >library facilities although they have not logged into koha >--- > C4/SIP/ILS/Patron.pm | 11 +++++++++++ > C4/SIP/Sip/MsgType.pm | 1 + > 2 files changed, 12 insertions(+) > >diff --git a/C4/SIP/ILS/Patron.pm b/C4/SIP/ILS/Patron.pm >index 0012776..35c62b6 100644 >--- a/C4/SIP/ILS/Patron.pm >+++ b/C4/SIP/ILS/Patron.pm >@@ -24,6 +24,7 @@ use C4::Items qw( GetBarcodeFromItemnumber GetItemnumbersForBiblio); > use C4::Auth qw(checkpw); > > use Koha::Libraries; >+use Koha::Patrons; > > our $kp; # koha patron > >@@ -411,6 +412,16 @@ sub charge_denied { > return "Please contact library staff"; > } > >+sub update_lastseen { >+ my $self = shift; >+ my $p; >+ if (C4::Context->preference('TrackLastPatronActivity') >+ && $p = Koha::Patrons->find({ borrowernumber => $self->{borrowernumber} })) { >+ $p->track_login; >+ } >+ return; >+} >+ > sub _get_address { > my $patron = shift; > >diff --git a/C4/SIP/Sip/MsgType.pm b/C4/SIP/Sip/MsgType.pm >index 7a1a1e3..9506fb9 100644 >--- a/C4/SIP/Sip/MsgType.pm >+++ b/C4/SIP/Sip/MsgType.pm >@@ -932,6 +932,7 @@ sub handle_patron_info { > > $resp = (PATRON_INFO_RESP); > if ($patron) { >+ $patron->update_lastseen(); > $resp .= patron_status_string($patron); > $resp .= ( defined($lang) and length($lang) == 3 ) ? $lang : $patron->language; > $resp .= timestamp(); >-- >2.9.4 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18625
:
63533
|
67953
|
67954
|
68650
|
68651
|
68652
|
72557
|
72558
|
73920
|
73921
|
73922