Bugzilla – Attachment 63598 Details for
Bug 18552
Borrower debarments do not show on member detail page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18552: [16.11.X] [QA Follow-up] Resolve warnings
Bug-18552-1611X-QA-Follow-up-Resolve-warnings.patch (text/plain), 2.23 KB, created by
Marcel de Rooy
on 2017-05-22 07:54:53 UTC
(
hide
)
Description:
Bug 18552: [16.11.X] [QA Follow-up] Resolve warnings
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2017-05-22 07:54:53 UTC
Size:
2.23 KB
patch
obsolete
>From 1caaa218ccae33fa5b5b2268075ab8df88c6d57c Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 19 May 2017 12:22:03 +0200 >Subject: [PATCH] Bug 18552: [16.11.X] [QA Follow-up] Resolve warnings >Content-Type: text/plain; charset=utf-8 > >Like: >Problem = a value of AutoResumeSuspendedHolds has been passed to param without key at /usr/share/koha/masterclone/C4/Templates.pm line 137. >Problem = a value of relatives_borrowernumbers has been passed to param without key at /usr/share/koha/masterclone/C4/Templates.pm line 137. > >Problem is functions returning undef in list context (in this case >housebound_role). >No need to call Patrons::find a second time. > >Note: The call of GetDebarments in the first patch suffered from this too. >It is in a fine place now too. But strictly speaking, should not have been >moved. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > members/moremember.pl | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > >diff --git a/members/moremember.pl b/members/moremember.pl >index 2d996ef..df9f0d2 100755 >--- a/members/moremember.pl >+++ b/members/moremember.pl >@@ -326,6 +326,7 @@ if (C4::Context->preference('EnhancedMessagingPreferences')) { > $template->param( $data->{'categorycode'} => 1 ); > $template->param( > patron => $patron, >+ borrower => $patron, # TODO Still needed by includes, > detailview => 1, > borrowernumber => $borrowernumber, > othernames => $data->{'othernames'}, >@@ -336,11 +337,11 @@ $template->param( > totaldue => sprintf("%.2f", $total), > totaldue_raw => $total, > overdues_exist => $overdues_exist, >- StaffMember => ($category_type eq 'S'), >- is_child => ($category_type eq 'C'), >+ StaffMember => $category_type eq 'S', >+ is_child => $category_type eq 'C', > samebranch => $samebranch, > quickslip => $quickslip, >- housebound_role => $patron->housebound_role, >+ housebound_role => scalar $patron->housebound_role, > privacy_guarantor_checkouts => $data->{'privacy_guarantor_checkouts'}, > AutoResumeSuspendedHolds => C4::Context->preference('AutoResumeSuspendedHolds'), > SuspendHoldsIntranet => C4::Context->preference('SuspendHoldsIntranet'), >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18552
:
63551
|
63557
|
63576
|
63577
|
63597
| 63598