Bugzilla – Attachment 63605 Details for
Bug 18330
REST API: Date-time handling
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18330: (follow-up) Add note to update tests when upgrading Mojolicious
Bug-18330-follow-up-Add-note-to-update-tests-when-.patch (text/plain), 1.41 KB, created by
Lari Taskula
on 2017-05-22 09:04:38 UTC
(
hide
)
Description:
Bug 18330: (follow-up) Add note to update tests when upgrading Mojolicious
Filename:
MIME Type:
Creator:
Lari Taskula
Created:
2017-05-22 09:04:38 UTC
Size:
1.41 KB
patch
obsolete
>From f1c7fb6174b6ca0f911eeb07b28e9c159fd09d16 Mon Sep 17 00:00:00 2001 >From: Lari Taskula <lari.taskula@jns.fi> >Date: Fri, 24 Mar 2017 16:49:09 +0200 >Subject: [PATCH] Bug 18330: (follow-up) Add note to update tests when > upgrading Mojolicious > >I noticed this test file is broken with Mojolicious 7. It is because they >have replaced Mojo::JSON::_Bool with JSON::PP::Boolean. This patch adds >TODO comment to easily identify the issue when updating. >--- > t/db_dependent/Koha/Object.t | 6 ++++++ > 1 file changed, 6 insertions(+) > >diff --git a/t/db_dependent/Koha/Object.t b/t/db_dependent/Koha/Object.t >index 98a3e24..1e1f40d 100755 >--- a/t/db_dependent/Koha/Object.t >+++ b/t/db_dependent/Koha/Object.t >@@ -164,9 +164,15 @@ subtest 'TO_JSON tests' => sub { > my $updated_on = $patron->TO_JSON->{updated_on}; > my $lastseen = $patron->TO_JSON->{lastseen}; > >+ # TODO: >+ # Fix the following test when upgrading Mojolicious - Mojo::JSON::_Bool replaced with >+ # JSON::PP::Boolean > ok( $lost->isa('Mojo::JSON::_Bool'), 'Boolean attribute type is correct' ); > is( $lost, 1, 'Boolean attribute value is correct (true)' ); > >+ # TODO: >+ # Fix the following test when upgrading Mojolicious - Mojo::JSON::_Bool replaced with >+ # JSON::PP::Boolean > ok( $gonenoaddress->isa('Mojo::JSON::_Bool'), 'Boolean attribute type is correct' ); > is( $gonenoaddress, 0, 'Boolean attribute value is correct (false)' ); > >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18330
:
63603
|
63604
|
63605
|
69726
|
69727
|
69749
|
69750
|
69751
|
69851