Attachment 63612 Details for Bug 18642 – Bug 18642: Remove debug messages

[patch] Bug 18642: Remove debug messages

Bug-18642-Remove-debug-messages.patch (text/plain), 1.15 KB, created by Marc Véron on 2017-05-22 12:43:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marc Véron

Created: 2017-05-22 12:43:43 UTC

Size: 1.15 KB

patch

obsolete

>From bef7978ac2bad069cb63eec9f4e38a852ddbb8f1 Mon Sep 17 00:00:00 2001
>From: Josef Moravec <josef.moravec@gmail.com>
>Date: Mon, 22 May 2017 10:38:02 +0000
>Subject: [PATCH] Bug 18642: Remove debug messages
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Test plan:
>0) Apply the patch
>1) git grep Data::Printer
>    -> should return no results
>2) Go to Reports -> Use saved - should work fine
>
>Signed-off-by: Marc VÃ©ron <veron@veron.ch>
>---
> reports/guided_reports.pl | 2 --
> 1 file changed, 2 deletions(-)
>
>diff --git a/reports/guided_reports.pl b/reports/guided_reports.pl
>index edff7d0..b81e84f 100755
>--- a/reports/guided_reports.pl
>+++ b/reports/guided_reports.pl
>@@ -110,8 +110,6 @@ elsif ( $phase eq 'Build new' ) {
>     if ( $op eq 'convert' ) {
>         my $report_id = $input->param('report_id');
>         my $report    = C4::Reports::Guided::get_saved_report($report_id);
>-        warn $report_id;
>-        use Data::Printer colored => 1; warn p $report;
>         if ($report) {
>             my $updated_sql = C4::Reports::Guided::convert_sql( $report->{savedsql} );
>             C4::Reports::Guided::update_sql(
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 18642: 63607 | 63609 | 63612 | 63615