Bugzilla – Attachment 63632 Details for
Bug 18651
Move of checkouts is still not correctly handled
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
DEBUG patches: I'd like feedback
DEBUG-patches-Id-like-feedback.patch (text/plain), 1.41 KB, created by
Jonathan Druart
on 2017-05-22 17:44:36 UTC
(
hide
)
Description:
DEBUG patches: I'd like feedback
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2017-05-22 17:44:36 UTC
Size:
1.41 KB
patch
obsolete
>From 41fa45e522b2705a53979620bc0810503f1604c8 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 22 May 2017 14:31:04 -0300 >Subject: [PATCH] DEBUG patches: I'd like feedback > >Check what the debug statement returns: there are 4 accountlines >entries, is that correct? > >https://bugs.koha-community.org/show_bug.cgi?id=18651 >--- > t/db_dependent/Circulation/Returns.t | 3 +++ > 1 file changed, 3 insertions(+) > >diff --git a/t/db_dependent/Circulation/Returns.t b/t/db_dependent/Circulation/Returns.t >index 69cf30965a..6d28cb4197 100644 >--- a/t/db_dependent/Circulation/Returns.t >+++ b/t/db_dependent/Circulation/Returns.t >@@ -302,6 +302,9 @@ subtest 'Handle ids duplication' => sub { > $account_lines = Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber, issue_id => $new_checkout->{issue_id} }); > is( $account_lines->count, 2, 'Two account lines should exist on new issue_id' ); > >+ $account_lines = Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber }); >+ use Data::Printer colored => 1; warn p $account_lines->unblessed; >+ > isnt( $original_checkout->issue_id, $new_checkout->{issue_id}, 'AddReturn should return the issue with the new issue_id' ); > isnt( $old_checkout->itemnumber, $item->{itemnumber}, 'If an item is checked-in, it should be moved to old_issues even if the issue_id already existed in the table' ); > }; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18651
:
63629
|
63630
|
63631
|
63632
|
63633
|
63634
|
63635
|
63636
|
63637
|
63654
|
63659
|
63706
|
64352
|
64353
|
64354
|
64355
|
64356
|
64357
|
64394
|
64395
|
64396
|
64397
|
64398
|
64399
|
64448
|
64449
|
64450
|
64451
|
64452
|
64453
|
64454
|
64455
|
64489
|
64490
|
64495
|
65134