Bugzilla – Attachment 63730 Details for
Bug 18611
Create labels action fails in manage-marc-import.pl if an item has been deleted from the import batch
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18611: [QA Follow-up] Make SQL query more readable
Bug-18611-QA-Follow-up-Make-SQL-query-more-readabl.patch (text/plain), 1.40 KB, created by
Marcel de Rooy
on 2017-05-26 08:27:36 UTC
(
hide
)
Description:
Bug 18611: [QA Follow-up] Make SQL query more readable
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2017-05-26 08:27:36 UTC
Size:
1.40 KB
patch
obsolete
>From d9c66ee8c0fb415ee3f279833855c910853c1401 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 26 May 2017 10:20:00 +0200 >Subject: [PATCH] Bug 18611: [QA Follow-up] Make SQL query more readable >Content-Type: text/plain; charset=utf-8 > >Make it more explicit by adding join statements. > >Test plan: >See next patch for adding a unit test. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/ImportBatch.pm | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > >diff --git a/C4/ImportBatch.pm b/C4/ImportBatch.pm >index 4ac5618..1b598c7 100644 >--- a/C4/ImportBatch.pm >+++ b/C4/ImportBatch.pm >@@ -1059,7 +1059,12 @@ sub GetImportBatchRangeDesc { > sub GetItemNumbersFromImportBatch { > my ($batch_id) = @_; > my $dbh = C4::Context->dbh; >- my $sth = $dbh->prepare("SELECT items.itemnumber FROM import_batches,import_records,import_items, items WHERE import_batches.import_batch_id=import_records.import_batch_id AND import_records.import_record_id=import_items.import_record_id AND items.itemnumber=import_items.itemnumber AND import_batches.import_batch_id=?"); >+ my $sql = q| >+SELECT itemnumber FROM import_items >+INNER JOIN items USING (itemnumber) >+INNER JOIN import_records USING (import_record_id) >+WHERE import_batch_id = ?|; >+ my $sth = $dbh->prepare( $sql ); > $sth->execute($batch_id); > my @items ; > while ( my ($itm) = $sth->fetchrow_array ) { >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18611
:
63483
|
63667
|
63668
|
63669
|
63728
|
63729
| 63730 |
63731