Bugzilla – Attachment 63740 Details for
Bug 18669
RewriteCond affecting wrong rule in koha-httpd.conf
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18669 - RewriteCond affecting wrong rule in koha-httpd.conf
Bug-18669---RewriteCond-affecting-wrong-rule-in-ko.patch (text/plain), 2.39 KB, created by
Marcel de Rooy
on 2017-05-26 10:05:14 UTC
(
hide
)
Description:
Bug 18669 - RewriteCond affecting wrong rule in koha-httpd.conf
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2017-05-26 10:05:14 UTC
Size:
2.39 KB
patch
obsolete
>From c3ec217bed1f6a66fb7d573cef7b707e1b05bbf2 Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Thu, 25 May 2017 14:37:21 +1000 >Subject: [PATCH] Bug 18669 - RewriteCond affecting wrong rule in > koha-httpd.conf >Content-Type: text/plain; charset=utf-8 > >One of the RewriteCond directives in koha-httpd.conf was affecting >the wrong RewriteRule after its original RewriteRule was commented out >years ago. > >_TEST PLAN_ >0) Before applying patch, build Koha from source > *) make > *) make install (or make upgrade) > *) Copy or symlink etc/koha-httpd.conf to your Apache vhost directory > (and enable if you're on a Debian based system) > *) Restart Apache >1) Make sure that you have at least 1 bibliographic record in Koha >(URL like this http://server:port/cgi-bin/koha/opac-detail.pl?biblionumber=1) >2) Go to http://server:port/bib/1 >3) Note that you get a 404 error >4) Apply the patch >5) Rebuild Koha from source as per step 0 >6) Go to http://server:port/bib/1 >7) Note that you now see the same page as you would if you went to >http://server:port/cgi-bin/koha/opac-detail.pl?biblionumber=1 > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > etc/koha-httpd.conf | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > >diff --git a/etc/koha-httpd.conf b/etc/koha-httpd.conf >index 2747791..c3b55a4 100644 >--- a/etc/koha-httpd.conf >+++ b/etc/koha-httpd.conf >@@ -105,7 +105,8 @@ > #RewriteLog __LOG_DIR__/koha-opac-rewrite.log > #RewriteLogLevel 1 > >- RewriteCond %{QUERY_STRING} (.*?)(?:[A-Za-z0-9_-]+)=&(.*) >+ #The following two directives are unnecessary to proper Koha functioning. >+ #RewriteCond %{QUERY_STRING} (.*?)(?:[A-Za-z0-9_-]+)=&(.*) > #RewriteRule (.+) $1?%1%2 [N,R,NE] > RewriteRule ^/bib/([^\/]*)/?$ /cgi-bin/koha/opac-detail\.pl?bib=$1 [PT] > RewriteRule ^/isbn/([^\/]*)/?$ /search?q=isbn:$1 [PT] >@@ -221,7 +222,8 @@ > #RewriteLog __LOG_DIR__/koha-intranet-rewrite.log > #RewriteLogLevel 1 > >- RewriteCond %{QUERY_STRING} (.*?)(?:[A-Za-z0-9_-]+)=&(.*) >+ #The following two directives are unnecessary to proper Koha functioning. >+ #RewriteCond %{QUERY_STRING} (.*?)(?:[A-Za-z0-9_-]+)=&(.*) > #RewriteRule (.+) $1?%1%2 [N,R,NE] > RewriteRule ^/bib/([^\/]*)/?$ /cgi-bin/koha/detail\.pl?bib=$1 [PT] > RewriteRule ^/isbn/([^\/]*)/?$ /search?q=isbn:$1 [PT] >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18669
:
63709
|
63711
| 63740