Bugzilla – Attachment 63890 Details for
Bug 18706
subfields to delete not disabled anymore in batch item modification
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 18706 - subfields to delete not disabled anymore in batch item modification
SIGNED-OFF-Bug-18706---subfields-to-delete-not-dis.patch (text/plain), 2.10 KB, created by
Josef Moravec
on 2017-05-31 19:58:00 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 18706 - subfields to delete not disabled anymore in batch item modification
Filename:
MIME Type:
Creator:
Josef Moravec
Created:
2017-05-31 19:58:00 UTC
Size:
2.10 KB
patch
obsolete
>From 0e3b23c13bcfebeb3a77ef20c86fc7249feb61fe Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Wed, 31 May 2017 16:02:44 +0200 >Subject: [PATCH] [SIGNED-OFF] Bug 18706 - subfields to delete not disabled > anymore in batch item modification > >In Tools > Batch item modification, one can click a checkbox to delete a subfield. >This click use to disable the input to change the field value. > >This comes from the patch : Bug 13501: Move "Required" and checkbox after input/select >Because input is found using JQuery next(). > >This patch replaces with $(this).parent().find("[name='field_value']"). > >Test plan : >- Go to Tools > Batch item modification >- Enter a barcode and submit >- Click on a checkbox on a non-mandatory subfield >=> Without patch the input or select is not disabled >=> With patch the input or select is disabled >- Submit >=> Check that subfield is deleted > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt >index c04733c..91c5214 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt >@@ -22,13 +22,13 @@ $(document).ready(function(){ > $("input[name='disable_input']").click(function() { > var row = $(this).attr("id"); > row = row.replace("row","hint"); >- var subfield = $(this).next(); >- if ($(this).is(":checked")){ >+ var editor = $(this).parent().find("[name='field_value']"); >+ if ($(this).is(":checked")) { > $(this).val($(this).siblings("[name='subfield']").val()); >- $(subfield).prop('disabled', true); >+ $(editor).prop('disabled', true); > $("#"+row).html(_("This subfield will be deleted")); > } else { >- $(subfield).prop('disabled', false); >+ $(editor).prop('disabled', false); > $("#"+row).html(""); > } > }); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18706
:
63864
|
63865
|
63890
|
63891
|
64152
|
64153