Bugzilla – Attachment 63991 Details for
Bug 18644
Translatability: Get rid of pure template directives in translation for memberentrygen.tt
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18644: Translatability: Get rid of pure template directives in translation for memberentrygen.tt
Bug-18644-Translatability-Get-rid-of-pure-template.patch (text/plain), 6.93 KB, created by
Jonathan Druart
on 2017-06-05 20:05:16 UTC
(
hide
)
Description:
Bug 18644: Translatability: Get rid of pure template directives in translation for memberentrygen.tt
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2017-06-05 20:05:16 UTC
Size:
6.93 KB
patch
obsolete
>From 5a30dea05b158fd6a77b0495ee047310865072eb Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch> >Date: Tue, 30 May 2017 11:23:20 +0200 >Subject: [PATCH] Bug 18644: Translatability: Get rid of pure template > directives in translation for memberentrygen.tt > >Translation for memberentrygen.tt exposes a lot of template directives >like the following: >[% UNLESS opduplicate %][% othernames | html %][% END %] >Translators should not be confronted with such code internals. > >To test: >- Review code changes >- Verify that creating / editing patrons works as before >- Bonus test: Create a "language" aa-AA (perl translate create aa-AA > from folder misc/translator, verify that lines like mentioned above > do no longer appear in aa-AA-staff-prog.po > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > .../prog/en/modules/members/memberentrygen.tt | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >index 870529555d..73cb4d60a5 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >@@ -230,8 +230,8 @@ $(document).ready(function() { > <input type="hidden" name="updtype" value="[% updtype %]" /> > <input type="hidden" name="destination" value="[% destination %]" /> > <input type="hidden" name="check_member" value="[% check_member %]" /> >-<input type="hidden" name="borrowernumber" value="[% UNLESS opduplicate %][% borrowernumber %][% END %]" /> >-<input type="hidden" name="nodouble" value="[% UNLESS opduplicate %][% nodouble %][% END %]" /> >+<input type="hidden" name="borrowernumber" value="[% borrowernumber UNLESS opduplicate %]" /> >+<input type="hidden" name="nodouble" value="[% nodouble UNLESS opduplicate %]" /> > <input type="hidden" name="csrf_token" value="[% csrf_token %]" /> > [% IF ( step ) %]<input type="hidden" name="step" value="[% step %]" />[% END %] > [% IF ( opadd ) %]<input type="hidden" name="op" value="insert" /> >@@ -302,7 +302,7 @@ $(document).ready(function() { > <label for="firstname"> > [% END %] > First name: </label> >- <input type="text" id="firstname" name="firstname" size="20" value="[% UNLESS opduplicate %][% firstname | html %][% END %]" /> >+ <input type="text" id="firstname" name="firstname" size="20" value="[% firstname | html UNLESS opduplicate %]" /> > [% IF ( mandatoryfirstname ) %]<span class="required">Required</span>[% END %] > </li> > [% END %] >@@ -315,7 +315,7 @@ $(document).ready(function() { > [% END %] > Date of birth: </label> > >- <input type="text" id="dateofbirth" name="dateofbirth" size="20" onchange="write_age();" value="[% UNLESS opduplicate %][% dateofbirth %][% END %]" class="datepicker" /> >+ <input type="text" id="dateofbirth" name="dateofbirth" size="20" onchange="write_age();" value="[% dateofbirth UNLESS opduplicate %]" class="datepicker" /> > > [% IF ( mandatorydateofbirth ) %]<span class="required">Required</span>[% END %] > [% IF ( ERROR_dateofbirth ) %]<span class="required">(Error)</span>[% END %] >@@ -330,7 +330,7 @@ $(document).ready(function() { > <label for="initials"> > [% END %] > Initials: </label> >- <input type="text" id="initials" name="initials" size="20" value="[% UNLESS opduplicate %][% initials | html %][% END %]" /> >+ <input type="text" id="initials" name="initials" size="20" value="[% initials | html UNLESS opduplicate %]" /> > [% IF ( mandatoryinitials ) %]<span class="required">Required</span>[% END %] > </li> > [% END %] >@@ -343,7 +343,7 @@ $(document).ready(function() { > <label for="othernames"> > [% END %] > Other name: </label> >- <input type="text" id="othernames" name="othernames" size="20" value="[% UNLESS opduplicate %][% othernames | html %][% END %]" /> >+ <input type="text" id="othernames" name="othernames" size="20" value="[% othernames | html UNLESS opduplicate %]" /> > [% IF ( mandatoryothernames ) %]<span class="required">Required</span>[% END %] > [% IF ( I ) %]<input type="hidden" name="sex" value="N" />[% END %] > </li> >@@ -779,13 +779,13 @@ $(document).ready(function() { > Expiry date (leave blank for auto calc): </label> > [% IF ( dateformat == "metric" ) %] > [% UNLESS ( opadd ) %] >- <input type="text" id="to" name="dateexpiry" maxlength="10" size="10" onchange="CheckDate(document.form.dateexpiry);check_manip_date('verify');" value="[% UNLESS opduplicate %][% dateexpiry %][% END %]" class="datepickerto" /> >+ <input type="text" id="to" name="dateexpiry" maxlength="10" size="10" onchange="CheckDate(document.form.dateexpiry);check_manip_date('verify');" value="[% dateexpiry UNLESS opduplicate %]" class="datepickerto" /> > [% ELSE %] > <input type="text" id="to" name="dateexpiry" maxlength="10" size="10" onchange="CheckDate(document.form.dateexpiry);check_manip_date('verify');" class="datepickerto" /> > [% END %] > [% ELSE %] > [% UNLESS ( opadd ) %] >- <input type="text" id="to" name="dateexpiry" maxlength="10" size="10" value="[% UNLESS opduplicate %][% dateexpiry %][% END %]" class="datepickerto" /> >+ <input type="text" id="to" name="dateexpiry" maxlength="10" size="10" value="[% dateexpiry UNLESS opduplicate %]" class="datepickerto" /> > [% ELSE %] > <input type="text" id="to" name="dateexpiry" maxlength="10" size="10" class="datepickerto" /> > [% END %] >@@ -802,7 +802,7 @@ $(document).ready(function() { > <label for="opacnote"> > [% END %] > OPAC note: </label> >- <textarea id="opacnote" name="opacnote" cols="55" rows="5">[% UNLESS opduplicate %][% opacnote | html %][% END %]</textarea> >+ <textarea id="opacnote" name="opacnote" cols="55" rows="5">[% opacnote | html UNLESS opduplicate %]</textarea> > <div class="hint">This message appears on this patron's user page in the OPAC</div> > [% IF ( mandatoryopacnote ) %]<span class="required">Required</span>[% END %] > </li> >@@ -815,7 +815,7 @@ $(document).ready(function() { > <label for="borrowernotes"> > [% END %] > Circulation note: </label> >- <textarea id="borrowernotes" name="borrowernotes" cols="55" rows="5">[% UNLESS opduplicate %][% borrowernotes | html %][% END %]</textarea> >+ <textarea id="borrowernotes" name="borrowernotes" cols="55" rows="5">[% borrowernotes | html UNLESS opduplicate %]</textarea> > <div class="hint">This message displays when checking out to this patron</div> > [% IF ( mandatoryborrowernotes ) %]<span class="required">Required</span>[% END %] > </li> >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18644
:
63586
|
63839
| 63991