@@ -, +, @@ sms_send_config -- it will be noisy, but pass. -- noise gone, test added --- C4/SMS.pm | 4 ++++ t/SMS.t | 11 ++++++++++- 2 files changed, 14 insertions(+), 1 deletion(-) --- a/C4/SMS.pm +++ a/C4/SMS.pm @@ -89,6 +89,10 @@ sub send_sms { my $driver = exists $params->{'driver'} ? $params->{'driver'} : $self->driver(); return unless $driver; + if ( ! defined C4::Context->config('sms_send_config') ) { + # Should I warn in some way? + return; + } my ($sent, $sender); --- a/t/SMS.t +++ a/t/SMS.t @@ -19,7 +19,7 @@ use Modern::Perl; use t::lib::Mocks; -use Test::More tests => 7; +use Test::More tests => 8; BEGIN { use_ok('C4::SMS'); @@ -53,6 +53,15 @@ $send_sms = C4::SMS->send_sms({ }); is( $send_sms, undef, 'send_sms with an undef driver returns undef' ); +t::lib::Mocks::mock_config('sms_send_config',undef); +$send_sms = C4::SMS->send_sms({ + destination => '+33123456789', + message => 'my message', + driver => 'Test', +}); +is( $send_sms, undef, 'send_sms without sms_send_config defined returns undef' ); + +t::lib::Mocks::mock_config('sms_send_config','\tmp'); $send_sms = C4::SMS->send_sms({ destination => '+33123456789', message => 'my message', --