Bugzilla – Attachment 64092 Details for
Bug 18753
t/00-testcritic.t fails Perl::Critic on test 221
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18753: t/00-testcritic.t fails
Bug-18753-t00-testcritict-fails.patch (text/plain), 1.07 KB, created by
Mark Tompsett
on 2017-06-07 23:38:25 UTC
(
hide
)
Description:
Bug 18753: t/00-testcritic.t fails
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2017-06-07 23:38:25 UTC
Size:
1.07 KB
patch
obsolete
>From a7d58af22b57f29f619b677c02ff32431016131d Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Wed, 7 Jun 2017 19:35:01 -0400 >Subject: [PATCH] Bug 18753: t/00-testcritic.t fails > >TEST PLAN >--------- >$ export TEST_QA=1 >$ sudo apt-get install libtest-perl-critic-perl >$ prove t/00-testcritic.t >-- test 221 will fail >apply patch >$ prove t/00-testcritic.t >-- all tests will pass >--- > reserve/request.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/reserve/request.pl b/reserve/request.pl >index 9ec204c..e5d106d 100755 >--- a/reserve/request.pl >+++ b/reserve/request.pl >@@ -311,7 +311,7 @@ foreach my $biblionumber (@biblionumbers) { > > ## Here we go backwards again to create hash of biblioitemnumber to itemnumbers, > ## when by definition all of the itemnumber have the same biblioitemnumber >- my ( $itemnumbers_of_biblioitem, $iteminfos_of); >+ my ( %itemnumbers_of_biblioitem, $iteminfos_of); > while ( my $item = $items->next ) { > $item = $item->unblessed; > my $biblioitemnumber = $item->{biblioitemnumber}; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18753
:
64090
|
64092
|
64093