From 00f043c5b8f5f7b7452d93d3aa9cccb827a934e4 Mon Sep 17 00:00:00 2001 From: Lee Jamison Date: Wed, 7 Jun 2017 13:25:41 +0000 Subject: [PATCH] Bug 18753 - t/00-testcritic fails Perl::Critic Bug Description: When performing a unit test on t/00-testcritic.t with the command 'prove t/00-testcritic.t' test 221 fails Perl::Critic with not ok 221 - Test::Perl::Critic for "reserve/request.pl" Failed test 'Test::Perl::Critic for "reserve/request.pl"' at /usr/share/perl5/Test/Perl/Critic.pm line 110. Perl::Critic found these violations in "reserve/request.pl": "$itemnumbers_of_biblioitem" is declared but not used at line 314, column 5. Unused variables clutter code and make it harder to read (Severity: 3) Cause of bug: The variable $itemnumbers_of_biblioitem is declared but never used in reserve/request.pl which causes the Perl::Critic violation. Patch Description: This patch removes the variable $itemnumbers_of_biblioitem from reserve/request.pl in order to satisfy Perl::Critic. The variable $itemnumbers_of_biblioitem is never used anywhere in reserve/request.pl other than its declaration so it should not cause any undesired effects. Test Plan: 1) Drop into koha-shell and run the command 'prove t/00-testcritic.t'. 2) Test 221 fails. 3) Apply the patch. 4) Re-run 'prove t/00-testcritic.t'. 5) All of the tests pass now. 6) Quit out of koha-shell. Signed-off-by: Mark Tompsett --- reserve/request.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/reserve/request.pl b/reserve/request.pl index 9ec204c..db35e16 100755 --- a/reserve/request.pl +++ b/reserve/request.pl @@ -311,7 +311,7 @@ foreach my $biblionumber (@biblionumbers) { ## Here we go backwards again to create hash of biblioitemnumber to itemnumbers, ## when by definition all of the itemnumber have the same biblioitemnumber - my ( $itemnumbers_of_biblioitem, $iteminfos_of); + my ( $iteminfos_of ); while ( my $item = $items->next ) { $item = $item->unblessed; my $biblioitemnumber = $item->{biblioitemnumber}; -- 2.1.4