Bugzilla – Attachment 64106 Details for
Bug 18296
C4::Items - Remove GetItemInfosOf
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18296: Remove perlcritic error (request.pl)
Bug-18296-Remove-perlcritic-error-requestpl.patch (text/plain), 1.04 KB, created by
Jonathan Druart
on 2017-06-08 15:00:23 UTC
(
hide
)
Description:
Bug 18296: Remove perlcritic error (request.pl)
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2017-06-08 15:00:23 UTC
Size:
1.04 KB
patch
obsolete
>From 1700b9c05efd24b9b391aba0ba4c4477688b7b2e Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 8 Jun 2017 11:59:38 -0300 >Subject: [PATCH] Bug 18296: Remove perlcritic error (request.pl) > >"$itemnumbers_of_biblioitem" is declared but not used at line 314, >column 5. Unused variables clutter code and make it harder to read. >(Severity: 3) >--- > reserve/request.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/reserve/request.pl b/reserve/request.pl >index 9ec204c327..db35e165fa 100755 >--- a/reserve/request.pl >+++ b/reserve/request.pl >@@ -311,7 +311,7 @@ foreach my $biblionumber (@biblionumbers) { > > ## Here we go backwards again to create hash of biblioitemnumber to itemnumbers, > ## when by definition all of the itemnumber have the same biblioitemnumber >- my ( $itemnumbers_of_biblioitem, $iteminfos_of); >+ my ( $iteminfos_of ); > while ( my $item = $items->next ) { > $item = $item->unblessed; > my $biblioitemnumber = $item->{biblioitemnumber}; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18296
:
61224
|
61226
|
63888
|
63944
|
64050
|
64073
| 64106