From 2e6700e589903aa70468784e120f127af4ed4ba2 Mon Sep 17 00:00:00 2001 From: Mark Tompsett Date: Mon, 5 Jun 2017 18:18:07 -0400 Subject: [PATCH] Bug 18732: Noisy t/SMS.t triggered by koha_conf.xml without sms_send_config Upgraded systems may be lacking sms_send_config which makes t/SMS.t noisy. This tweaks the tests to compensate and change for missing case. Remove sms_send_config from your koha-conf.xml file prove t/SMS.t -- it will be noisy, but pass. apply patch prove t/SMS.t -- noise gone. run koha qa test tools. --- C4/SMS.pm | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/C4/SMS.pm b/C4/SMS.pm index c603117..e623e6c 100644 --- a/C4/SMS.pm +++ b/C4/SMS.pm @@ -89,6 +89,10 @@ sub send_sms { my $driver = exists $params->{'driver'} ? $params->{'driver'} : $self->driver(); return unless $driver; + if ( ! defined C4::Context->config('sms_send_config') ) { + # Should I warn in some way? + return; + } my ($sent, $sender); -- 2.1.4