From c35932923407e9ec088957f877e8607289b6b914 Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Thu, 1 Jun 2017 23:52:07 -0300 Subject: [PATCH] Bug 18716: Remove CGI::param warns from updatesupplier.pl MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This script floods the logs with this kind of warnings. To test: - Run: $ koha-plack-err - Edit a vendor in the acquisitions module - Save => FAIL: Logs show lots of warnings that look like: CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_acqui_updatesupplier_2epl - Apply this patch - Run: $ restart_all $ koha-plack-err - Edit a vendor, add/delete vendor contacts => SUCESS: No more warnings - Verify editing and storing vendor contacts works as expected. - Sign off :-D Signed-off-by: Marc VĂ©ron Signed-off-by: Jonathan Druart --- acqui/updatesupplier.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/acqui/updatesupplier.pl b/acqui/updatesupplier.pl index 822d7a0..18912dd 100755 --- a/acqui/updatesupplier.pl +++ b/acqui/updatesupplier.pl @@ -99,7 +99,7 @@ my @contacts; my %contact_info; foreach (qw(id name position phone altphone fax email notes orderacquisition claimacquisition claimissues acqprimary serialsprimary)) { - $contact_info{$_} = [ $input->param('contact_' . $_) ]; + $contact_info{$_} = [ $input->multi_param('contact_' . $_) ]; } for my $cnt (0..scalar(@{$contact_info{'id'}})) { -- 2.1.4