Bugzilla – Attachment 64167 Details for
Bug 18732
Noisy t/SMS.t triggered by koha_conf.xml without sms_send_config
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18732: Noisy t/SMS.t triggered by koha_conf.xml without sms_send_config
Bug-18732-Noisy-tSMSt-triggered-by-kohaconfxml-wit.patch (text/plain), 1.47 KB, created by
Lee Jamison
on 2017-06-09 17:42:16 UTC
(
hide
)
Description:
Bug 18732: Noisy t/SMS.t triggered by koha_conf.xml without sms_send_config
Filename:
MIME Type:
Creator:
Lee Jamison
Created:
2017-06-09 17:42:16 UTC
Size:
1.47 KB
patch
obsolete
>From 736c552a4c9c6179747afb482166806e46a9cf00 Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Mon, 5 Jun 2017 18:18:07 -0400 >Subject: [PATCH] Bug 18732: Noisy t/SMS.t triggered by koha_conf.xml without > sms_send_config > >Upgraded systems may be lacking sms_send_config which makes t/SMS.t noisy. >This silently bypasses the problem. > >Remove sms_send_config from your koha-conf.xml file >prove t/SMS.t >-- it will be noisy, but pass. >apply patch >prove t/SMS.t >-- noise gone. >run koha qa test tools. > >Signed-off-by: Lee Jamison <ldjamison@marywood.edu> >Works correctly as indicated by the testing plan. >No "uninitialized" noise after patch is applied. >--- > C4/SMS.pm | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > >diff --git a/C4/SMS.pm b/C4/SMS.pm >index c603117..90c5d40 100644 >--- a/C4/SMS.pm >+++ b/C4/SMS.pm >@@ -89,15 +89,17 @@ sub send_sms { > my $driver = exists $params->{'driver'} ? $params->{'driver'} : $self->driver(); > return unless $driver; > >- > my ($sent, $sender); > > my $subpath = $driver; > $subpath =~ s|::|/|; > >- my $conf_file = >- File::Spec->catfile( C4::Context->config('sms_send_config'), $subpath ) >- . q{.yaml}; >+ my $sms_send_config = C4::Context->config('sms_send_config'); >+ my $conf_file = ! defined $sms_send_config ? >+ $subpath : >+ File::Spec->catfile( $sms_send_config, $subpath ); >+ $conf_file .= q{.yaml}; >+ > my %args; > if ( -f $conf_file ) { > require YAML; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18732
:
64015
|
64016
|
64120
|
64121
|
64167
|
64285