From bd14d2db9c6f6ac34a1dc0ea4ab741c05c22e5d3 Mon Sep 17 00:00:00 2001 From: Mark Tompsett Date: Fri, 9 Jun 2017 19:23:49 -0400 Subject: [PATCH] Bug 18411: Fix failing search_utf8.t tests TEST PLAN --------- export KOHA_INTRANET_URL=... prove -v t/db_dependent/www/search_utf8.t something like seen before failure: t/db_dependent/www/search_utf8.t .. 9/66 Error GETing http://koha_16_11:8080/cgi-bin/koha/tools/background-job-progress.pl?jobID=741d649f9d4472fe75f30761ba2488c0: Bad Request at t/db_dependent/www/search_utf8.t line 170. apply this patch prove -v t/db_dependent/www/search_utf8.t Now it is the marc staging that is failing. And that is failing in master for me. So, I don't think it is the test that is a problem at this point, but the actual staged marc records process. Signed-off-by: Lee Jamison I'm not sure why you had problems. All 66 tests passed after patch application and the patch also passes QA Tools. I tested this patch on a brand new kohadevbox without issue. Signed-off-by: Jonathan Druart --- t/db_dependent/www/search_utf8.t | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/t/db_dependent/www/search_utf8.t b/t/db_dependent/www/search_utf8.t index 7a10888f8f..c0d3a272ea 100644 --- a/t/db_dependent/www/search_utf8.t +++ b/t/db_dependent/www/search_utf8.t @@ -168,9 +168,8 @@ sub test_search{ # if we haven't completed the batch in two minutes, it's not happening for my $counter ( 1 .. 24 ) { $agent->get( - "$intranet/cgi-bin/koha/tools/background-job-progress.pl?jobID=$jobID", - "get job progress" - ); + "$intranet/cgi-bin/koha/tools/background-job-progress.pl?jobID=$jobID" + ); # get job progress $jsonresponse = decode_json $agent->content(); if ( $jsonresponse->{'job_status'} eq 'completed' ) { $completed = 1; -- 2.11.0