Bugzilla – Attachment 64375 Details for
Bug 18804
Selenium tests are failing
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18804: (bugs 16400,11088 follow-up) Update the "save category" elt selector
Bug-18804-bugs-1640011088-follow-up-Update-the-sav.patch (text/plain), 1.74 KB, created by
Marcel de Rooy
on 2017-06-16 07:30:01 UTC
(
hide
)
Description:
Bug 18804: (bugs 16400,11088 follow-up) Update the "save category" elt selector
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2017-06-16 07:30:01 UTC
Size:
1.74 KB
patch
obsolete
>From aec45198f3c97c4f70d432dfa8a266c02c0084c8 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 14 Jun 2017 13:08:20 -0300 >Subject: [PATCH] Bug 18804: (bugs 16400,11088 follow-up) Update the "save > category" elt selector >Content-Type: text/plain; charset=utf-8 > >With bug 11088 and bug 16400 the submit node switched from: > <input type="submit" name="save" onclick="return check_form_borrowers();" value="Save" /> >to: > <button type="submit" name="save" onclick="return check_form_borrowers"> >then finally to: > <button class="btn btn-small" id="saverecord" type="submit" name="save" onclick="return check_form_borrowers();"> > >Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> > >Signed-off-by: Lee Jamison <ldjamison@marywood.edu> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > t/db_dependent/selenium/basic_workflow.t | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/t/db_dependent/selenium/basic_workflow.t b/t/db_dependent/selenium/basic_workflow.t >index fb5ca7b..945a442 100644 >--- a/t/db_dependent/selenium/basic_workflow.t >+++ b/t/db_dependent/selenium/basic_workflow.t >@@ -83,7 +83,7 @@ SKIP: { > $driver->get($base_url.'/members/memberentry.pl?op=add&categorycode='.$sample_data->{category}{categorycode}); > like( $driver->get_title(), qr(Add .*$sample_data->{category}{description}), ); > fill_form( $driver, $sample_data->{patron} ); >- $driver->find_element('//fieldset[@class="action"]/input[@type="submit"]')->click; >+ $driver->find_element('//button[@id="saverecord"]')->click; # Fix for bug 16400 > like( $driver->get_title(), qr(Patron details for $sample_data->{patron}{surname}), ); > > ####$driver->get($base_url.'/members/members-home.pl'); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18804
:
64289
|
64290
|
64291
|
64292
|
64358
|
64359
|
64360
|
64361
|
64362
|
64363
|
64365
|
64366
|
64367
|
64368
|
64373
|
64374
| 64375 |
64376
|
64417