From 3be7caee70a6c0aaaeaf333ad64b16d4eb82b12a Mon Sep 17 00:00:00 2001 From: Aleisha Amohia Date: Wed, 5 Apr 2017 00:13:38 +0000 Subject: [PATCH] Bug 18384: ShowAllAttachedSubsSerialCollection syspref Content-Type: text/plain; charset=utf-8 To test: 1) Apply patch and update database 2) Find ShowAllAttachedSubsSerialCollection syspref, confirm it is set to "Don't" 3) Go to Serials, find a serial with more than one subscription 4) Click Serial Collection, confirm you are taken to the subscription summary for that one subscription 5) Set syspref to 'Always' 6) Go back to serials and find that same serial 7) Click Serial Collection, confirm you can see the subscription summaries of all attached subs straight away. Sponsored-by: Catalyst IT Signed-off-by: Claire Gravely Signed-off-by: Marcel de Rooy Works fine, not convinced that we need it in view of another syspref. --- .../bug_18384_-_add_ShowAllAttachedSubsSerialCollection_syspref.sql | 1 + installer/data/mysql/sysprefs.sql | 1 + koha-tmpl/intranet-tmpl/prog/en/includes/serials-menu.inc | 6 +++++- .../intranet-tmpl/prog/en/modules/admin/preferences/serials.pref | 6 ++++++ 4 files changed, 13 insertions(+), 1 deletion(-) create mode 100644 installer/data/mysql/atomicupdate/bug_18384_-_add_ShowAllAttachedSubsSerialCollection_syspref.sql diff --git a/installer/data/mysql/atomicupdate/bug_18384_-_add_ShowAllAttachedSubsSerialCollection_syspref.sql b/installer/data/mysql/atomicupdate/bug_18384_-_add_ShowAllAttachedSubsSerialCollection_syspref.sql new file mode 100644 index 0000000..60b15b6 --- /dev/null +++ b/installer/data/mysql/atomicupdate/bug_18384_-_add_ShowAllAttachedSubsSerialCollection_syspref.sql @@ -0,0 +1 @@ +INSERT IGNORE INTO systempreferences (`variable`, `value`, `options`, `explanation`, `type`) VALUES ('ShowAllAttachedSubsSerialCollection', '0', NULL, 'If enabled, always show all attached subscriptions to a biblio in serial collection', 'YesNo'); diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql index 0bd8cac..ac32b71 100644 --- a/installer/data/mysql/sysprefs.sql +++ b/installer/data/mysql/sysprefs.sql @@ -477,6 +477,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` ('ShelfBrowserUsesCcode','1','0','Use the item collection code when finding items for the shelf browser.','YesNo'), ('ShelfBrowserUsesHomeBranch','1','1','Use the item home branch when finding items for the shelf browser.','YesNo'), ('ShelfBrowserUsesLocation','1','1','Use the item location when finding items for the shelf browser.','YesNo'), +('ShowAllAttachedSubsSerialCollection', '0', NULL, 'If enabled, always show all attached subscriptions to a biblio in serial collection', 'YesNo'), ('ShowAllCheckins', '0', '', 'Show all checkins', 'YesNo'), ('ShowPatronImageInWebBasedSelfCheck','0','','If ON, displays patron image when a patron uses web-based self-checkout','YesNo'), ('ShowReviewer','full','none|full|first|surname|firstandinitial|username','Choose how a commenter\'s identity is presented alongside comments in the OPAC','Choice'), diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/serials-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/serials-menu.inc index 21dff3a..3c5d269 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/serials-menu.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/serials-menu.inc @@ -1,6 +1,10 @@ [% IF ( subscriptionid ) %]
    -
  • Serial collection
  • + [% IF Koha.Preference('ShowAllAttachedSubsSerialCollection') %] +
  • Serial collection
  • + [% ELSE %] +
  • Serial collection
  • + [% END %] [% UNLESS closed %] [% IF ( routing && CAN_user_serials_routing ) %] [% IF ( hasRouting ) %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/serials.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/serials.pref index 76c89a8..af674d2 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/serials.pref +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/serials.pref @@ -1,5 +1,11 @@ Serials: - + - pref: ShowAllAttachedSubsSerialCollection + choices: + yes: Always + no: "Don't" + - show all attached subscriptions to a biblio in Serial Collection. + - - Show - pref: opacSerialDefaultTab choices: -- 2.1.4