Bugzilla – Attachment 6440 Details for
Bug 6628
[security] help system use insecure REFERRER for file inclusion
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 6628 : Stopping a potential vulnerability
SIGNED-OFF-Bug-6628--Stopping-a-potential-vulnerab.patch (text/plain), 1.28 KB, created by
Katrin Fischer
on 2011-11-28 07:40:49 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 6628 : Stopping a potential vulnerability
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2011-11-28 07:40:49 UTC
Size:
1.28 KB
patch
obsolete
>From 75a9699ae075cf799fd73124c1b02b0f035eb43d Mon Sep 17 00:00:00 2001 >From: Chris Cormack <chrisc@catalyst.net.nz> >Date: Sat, 26 Nov 2011 07:39:51 +1300 >Subject: [PATCH] [SIGNED-OFF] Bug 6628 : Stopping a potential vulnerability >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Signed-off-by: Frère Sébastien Marie <semarie-koha@latrappe.fr> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >- verified help pages still work >- verified /cgi-bin/koha/help.pl?url=koha/../catalogue/advsearch.pl does not >show the template file (did work on master, not after applying patch) >- verified cgi-bin/koha/help.pl?url=koha/../../../../../../etc/passwd%00.pl does not work (didn't work on master or after applying patch) >--- > help.pl | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > >diff --git a/help.pl b/help.pl >index 18d27dd..97f3462 100755 >--- a/help.pl >+++ b/help.pl >@@ -32,7 +32,9 @@ our $refer = $query->param('url'); > $refer = $query->referer() if !$refer || $refer eq 'undefined'; > > $refer =~ /koha\/(.*)\.pl/; >-my $from = "help/$1.tt"; >+my $file = $1; >+$file =~ s/[^a-zA-Z0-9_\-\/]*//g; >+my $from = "help/$file.tt"; > > my $template = C4::Templates::gettemplate($from, 'intranet', $query); > $template->param( referer => $refer ); >-- >1.7.5.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6628
:
6413
|
6417
| 6440 |
6443
|
6444