From 58b20f4f0650ee3c1af0b001001c93f67712d8e9 Mon Sep 17 00:00:00 2001 From: Baptiste Wojtkowski Date: Mon, 26 Jun 2017 10:25:44 +0000 Subject: [PATCH] Bug 13178: Correct Max cardnumberlength ($max is the value of the max size of a card number) - $max not hardcoded anymore in C4::Memeber - $max now correctly adapts to the field of cardnumber in database --- C4/Members.pm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/C4/Members.pm b/C4/Members.pm index 3e6592c..19493ca 100644 --- a/C4/Members.pm +++ b/C4/Members.pm @@ -956,7 +956,9 @@ database column. =cut sub get_cardnumber_length { - my ( $min, $max ) = ( 0, 32 ); # borrowers.cardnumber is a nullable varchar(20) + my $borrower = Koha::Schema->resultset('Borrower'); + my $field_size = $borrower->result_source->column_info('cardnumber')->{size}; + my ( $min, $max ) = ( 0, $field_size ); # borrowers.cardnumber is a nullable varchar(20) $min = 1 if C4::Context->preference('BorrowerMandatoryField') =~ /cardnumber/; if ( my $cardnumber_length = C4::Context->preference('CardnumberLength') ) { # Is integer and length match @@ -972,9 +974,7 @@ sub get_cardnumber_length { } } - my $borrower = Koha::Schema->resultset('Borrower'); - my $field_size = $borrower->result_source->column_info('cardnumber')->{size}; - $min = $field_size if $min > $field_size; + $min = $max if $min > $max; return ( $min, $max ); } -- 2.7.4