Bugzilla – Attachment 64692 Details for
Bug 14385
Extend OpacHiddenItems to allow specifying exempt borrower categories
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14385: Always use mocks, not set_preference
Bug-14385-Always-use-mocks-not-setpreference.patch (text/plain), 1.57 KB, created by
Mark Tompsett
on 2017-06-28 02:57:21 UTC
(
hide
)
Description:
Bug 14385: Always use mocks, not set_preference
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2017-06-28 02:57:21 UTC
Size:
1.57 KB
patch
obsolete
>From 90b545e81489076eb866371f7668ac1c52c058bb Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Tue, 27 Jun 2017 20:10:25 -0400 >Subject: [PATCH] Bug 14385: Always use mocks, not set_preference > >--- > t/db_dependent/Items.t | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > >diff --git a/t/db_dependent/Items.t b/t/db_dependent/Items.t >index 55e1c03..4fb7601 100755 >--- a/t/db_dependent/Items.t >+++ b/t/db_dependent/Items.t >@@ -155,12 +155,12 @@ subtest 'GetHiddenItemnumbers tests' => sub { > push @items, GetItem( $item2_itemnumber ); > > # Empty OpacHiddenItems >- C4::Context->set_preference('OpacHiddenItems',''); >+ t::lib::Mocks::mock_preference('OpacHiddenItems',''); > ok( !defined( GetHiddenItemnumbers( { items => \@items } ) ), > "Hidden items list undef if OpacHiddenItems empty"); > > # Blank spaces >- C4::Context->set_preference('OpacHiddenItems',' '); >+ t::lib::Mocks::mock_preference('OpacHiddenItems',' '); > ok( scalar GetHiddenItemnumbers( { items => \@items } ) == 0, > "Hidden items list empty if OpacHiddenItems only contains blanks"); > >@@ -176,7 +176,6 @@ subtest 'GetHiddenItemnumbers tests' => sub { > $opachiddenitems = " > withdrawn: [1,0]"; > t::lib::Mocks::mock_preference( 'OpacHiddenItems', $opachiddenitems ); >- C4::Context->set_preference( 'OpacHiddenItems', $opachiddenitems ); > @hidden = GetHiddenItemnumbers( { items => \@items } ); > ok( scalar @hidden == 2, "Two items hidden"); > is_deeply( \@hidden, \@itemnumbers, "withdrawn=1 and withdrawn=0 hidden"); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14385
:
40158
|
53483
|
53494
|
53505
|
53506
|
53507
|
55593
|
64688
|
64689
|
64690
|
64691
|
64692
|
64693
|
65322
|
65323
|
65324
|
65325
|
65376
|
65377
|
65378
|
65379
|
65380
|
65381
|
65382
|
65383
|
65384
|
65385
|
65386
|
65387
|
65388
|
65389
|
65408
|
65409
|
65410
|
65411
|
66103
|
66104
|
66105
|
66106
|
66107
|
66108
|
66109
|
66110
|
66111
|
66112
|
66113
|
66114
|
66115
|
66116
|
66117
|
66118
|
66125
|
66126
|
66127
|
66128
|
66129
|
66130
|
66131
|
66132
|
66192
|
66193
|
66194
|
66195
|
66196
|
66197
|
66198
|
66199
|
66200
|
66201
|
66202
|
66203
|
66204
|
66205
|
66206
|
66207
|
66208
|
66209
|
66210
|
66302
|
66303
|
66347
|
66361
|
66372
|
66401
|
66403
|
66520
|
66521
|
66522
|
66523
|
66524
|
66525
|
66526
|
66527
|
66528
|
66529
|
66530
|
66531
|
66532
|
66533
|
66534
|
66535
|
66536
|
66537
|
66538
|
66539
|
66540
|
66541
|
66542
|
66543
|
66544
|
66545
|
70256
|
70257
|
70258
|
70259
|
72445
|
72446
|
72447
|
72448
|
72449
|
72450
|
72451
|
72452
|
72453
|
72454
|
74001
|
78654
|
78655
|
78656
|
78657
|
78825
|
78826
|
78827
|
78828
|
80411
|
80463
|
80464
|
80465
|
80466
|
80467
|
89963
|
90038