Bugzilla – Attachment 64722 Details for
Bug 18633
Logs are full of CGI::param called in list context - itemsearch.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18633: Remove remaining use of CGI.param in template
Bug-18633-Remove-remaining-use-of-CGIparam-in-temp.patch (text/plain), 1.54 KB, created by
Marc Véron
on 2017-06-29 13:02:28 UTC
(
hide
)
Description:
Bug 18633: Remove remaining use of CGI.param in template
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2017-06-29 13:02:28 UTC
Size:
1.54 KB
patch
obsolete
>From 9feb5fa1e87f86df2b900f6beefea1d4910098d0 Mon Sep 17 00:00:00 2001 >From: Julian Maurice <julian.maurice@biblibre.com> >Date: Mon, 12 Jun 2017 09:18:30 +0200 >Subject: [PATCH] Bug 18633: Remove remaining use of CGI.param in template >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Signed-off-by: Marc Véron <veron@veron.ch> >--- > catalogue/itemsearch.pl | 1 + > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch_json.tt | 3 +-- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/catalogue/itemsearch.pl b/catalogue/itemsearch.pl >index 5f20dd3..b069128 100755 >--- a/catalogue/itemsearch.pl >+++ b/catalogue/itemsearch.pl >@@ -252,6 +252,7 @@ if (scalar keys %params > 0) { > print "$line\n" unless $line =~ m|^\s*$|; > } > } elsif ($format eq 'json') { >+ $template->param(sEcho => scalar $cgi->param('sEcho')); > output_with_http_headers $cgi, $cookie, $template->output, 'json'; > } > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch_json.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch_json.tt >index 35e020f..4bc2add 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch_json.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch_json.tt >@@ -1,6 +1,5 @@ >-[%- USE CGI -%] > { >- "sEcho": [% CGI.param('sEcho') %], >+ "sEcho": [% sEcho %], > "iTotalRecords": [% total_rows %], > "iTotalDisplayRecords": [% total_rows %], > "aaData": [ >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18633
:
64123
|
64193
|
64709
|
64710
|
64721
|
64722
|
64900
|
64901
|
65502
|
65503