Bugzilla – Attachment 64755 Details for
Bug 18771
CGI.pm: Subroutine multi_param redefined
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18771: CGI.pm: Subroutine multi_param redefined
Bug-18771-CGIpm-Subroutine-multiparam-redefined.patch (text/plain), 2.01 KB, created by
Mark Tompsett
on 2017-06-30 14:34:11 UTC
(
hide
)
Description:
Bug 18771: CGI.pm: Subroutine multi_param redefined
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2017-06-30 14:34:11 UTC
Size:
2.01 KB
patch
obsolete
>From cf2474f732348b7deed9e8ed1a442dbb69bbee2c Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Fri, 9 Jun 2017 13:01:14 -0400 >Subject: [PATCH] Bug 18771: CGI.pm: Subroutine multi_param redefined > >The commands in the test plan are examples, and may need varying >depending on your installation. This was created as a result >of attempting to clean the installation process up. However, >I believe the redefine might exist normally too. I just didn't >check. This is tested on a Debian 8 box sudo apt-get update'd >fully. > >TEST PLAN >--------- >empty error log >$ echo > ~/koha-dev/var/log/koha-error_log > >drop and recreate and empty db >> drop database koha_library; >> create database koha_library; >> quit > >run the web installer, but DO NOT LOG IN! >*opening chrome to Staff Client URL* > >check the error log >$ less ~/koha-dev/var/log/koha-error_log >... >[Fri Jun 09 13:08:52.793627 2017] [cgi:error] [pid 5802] [client 192.168.71.101:58169] AH01215: [Fri Jun 9 13:08:52 2017] CGI.pm: Subroutine multi_param redefined at /usr/share/perl5/CGI.pm line 419. >... > >apply patch > >empty error log >$ echo > ~/koha-dev/var/log/koha-error_log > >refresh the installation login page > >recheck the error log >$ less ~/koha-dev/var/log/koha-error_log > >notice no reference to "Subroutine multi_param redefined" > >run koha qa test tools > >Notice that it is just a require CGI; and comment added. > >Signed-off-by: Lee Jamison <ldjamison@marywood.edu> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/Context.pm | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/C4/Context.pm b/C4/Context.pm >index a50ddfd..1aa08be 100644 >--- a/C4/Context.pm >+++ b/C4/Context.pm >@@ -80,6 +80,7 @@ BEGIN { > > # Redefine multi_param if cgi version is < 4.08 > # Remove the "CGI::param called in list context" warning in this case >+ require CGI; # Can't check version without the require. > if (!defined($CGI::VERSION) || $CGI::VERSION < 4.08) { > no warnings 'redefine'; > *CGI::multi_param = \&CGI::param; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18771
:
64165
|
64166
|
64729
|
64730
|
64753
|
64754
| 64755