Bugzilla – Attachment 64761 Details for
Bug 18881
Remove dead code in circ/view_holdsqueue.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18881: Remove dead code in circ/view_holdsqueue.pl
Bug-18881-Remove-dead-code-in-circviewholdsqueuepl.patch (text/plain), 1.38 KB, created by
Marc Véron
on 2017-06-30 18:30:07 UTC
(
hide
)
Description:
Bug 18881: Remove dead code in circ/view_holdsqueue.pl
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2017-06-30 18:30:07 UTC
Size:
1.38 KB
patch
obsolete
>From 59ded43ccb0392ea99f0493f18e77fe930daf822 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch> >Date: Fri, 30 Jun 2017 20:20:44 +0200 >Subject: [PATCH] Bug 18881: Remove dead code in circ/view_holdsqueue.pl > >Remove a line of dead code from circ/view_holdsqueue.pl > >To test: >- Apply patch >- Go to Home > Circulation > Holds queue >- Verify that description in Item type column displays as before >- Create a translation for an item type: > Home > Administration > Item types > Modify item type 'BK' > There you have a link 'Translate into other languages' to create translations > To test, you can even 'translate' for English to overwrite the original > description. >- Verify that the translated descriptions displays when changing the language > as appropriate >- For an explanation how translation of item types descriptions work and why > it is not done with Pootle see comment #7 >--- > circ/view_holdsqueue.pl | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/circ/view_holdsqueue.pl b/circ/view_holdsqueue.pl >index 7c09754..2792bd3 100755 >--- a/circ/view_holdsqueue.pl >+++ b/circ/view_holdsqueue.pl >@@ -68,7 +68,6 @@ my @itemtypesloop; > while ( my $itemtype = $itemtypes->next ) { > push @itemtypesloop, { > value => $itemtype->itemtype, >- description => $itemtype->description, # FIXME Don't we want the translated_description here? > }; > } > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18881
:
64726
|
64761
|
64769
|
64770