Bugzilla – Attachment 64769 Details for
Bug 18881
Remove dead code in circ/view_holdsqueue.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18881: Remove dead code from view_holdsqueue.pl
Bug-18881-Remove-dead-code-from-viewholdsqueuepl.patch (text/plain), 1.02 KB, created by
Marcel de Rooy
on 2017-07-03 07:51:27 UTC
(
hide
)
Description:
Bug 18881: Remove dead code from view_holdsqueue.pl
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2017-07-03 07:51:27 UTC
Size:
1.02 KB
patch
obsolete
>From 886ee2d744650542e6a6e4649f3dffab871060d0 Mon Sep 17 00:00:00 2001 >From: =?utf-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch> >Date: Fri, 30 Jun 2017 20:20:44 +0200 >Subject: [PATCH] Bug 18881: Remove dead code from view_holdsqueue.pl >Content-Type: text/plain; charset=utf-8 > >Aleisha spotted the typo in $itemtypes and proposed a correction on bug 18859. >The description was not even used. Template calls GetDescription. > >To test: >Verify that viewing the holds queue still works as expected. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > circ/view_holdsqueue.pl | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/circ/view_holdsqueue.pl b/circ/view_holdsqueue.pl >index 75b02d5..2792bd3 100755 >--- a/circ/view_holdsqueue.pl >+++ b/circ/view_holdsqueue.pl >@@ -68,7 +68,6 @@ my @itemtypesloop; > while ( my $itemtype = $itemtypes->next ) { > push @itemtypesloop, { > value => $itemtype->itemtype, >- description => $itemtypes->description, # FIXME Don't we want the translated_description here? > }; > } > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18881
:
64726
|
64761
| 64769 |
64770