Bugzilla – Attachment 64770 Details for
Bug 18881
Remove dead code in circ/view_holdsqueue.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18881: [QA Follow-up] Remove even more
Bug-18881-QA-Follow-up-Remove-even-more.patch (text/plain), 2.61 KB, created by
Marcel de Rooy
on 2017-07-03 07:51:31 UTC
(
hide
)
Description:
Bug 18881: [QA Follow-up] Remove even more
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2017-07-03 07:51:31 UTC
Size:
2.61 KB
patch
obsolete
>From 2a2880717e0a9f69c135e2a1ebad9b759b02472c Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Mon, 3 Jul 2017 09:31:52 +0200 >Subject: [PATCH] Bug 18881: [QA Follow-up] Remove even more >Content-Type: text/plain; charset=utf-8 > >Removing the commented section from the template: If it does not work, it should not be here. >When it works again, put it back in. > >Since @itemtypesloop is not used, remove it from the script too. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > circ/view_holdsqueue.pl | 13 ------------- > .../intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt | 11 ----------- > 2 files changed, 24 deletions(-) > >diff --git a/circ/view_holdsqueue.pl b/circ/view_holdsqueue.pl >index 2792bd3..3d8649a 100755 >--- a/circ/view_holdsqueue.pl >+++ b/circ/view_holdsqueue.pl >@@ -62,19 +62,6 @@ if ( $run_report ) { > ); > } > >-# getting all itemtypes >-my $itemtypes = Koha::ItemTypes->search({}, {order_by => 'itemtype'});; >-my @itemtypesloop; >-while ( my $itemtype = $itemtypes->next ) { >- push @itemtypesloop, { >- value => $itemtype->itemtype, >- }; >-} >- >-$template->param( # FIXME Could be improved passing the $itemtypes iterator directly to the template >- itemtypeloop => \@itemtypesloop, >-); >- > # Checking if there is a Fast Cataloging Framework > $template->param( fast_cataloging => 1 ) if Koha::BiblioFrameworks->find( 'FA' ); > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt >index 509e5ba..75411cc 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt >@@ -209,17 +209,6 @@ $(document).ready(function() { > [% PROCESS options_for_libraries libraries => Branches.all() %] > </select> > </li> >- <!-- FIXME Not working yet >- <li><label for="itemtypeslimit">Item Type: </label><select name="itemtypeslimit" id="itemtypeslimit"> >- <option value="">All</option> >- [% FOREACH itemtypeloo IN itemtypeloop %] >- [% IF ( itemtypeloo.selected ) %]<option value="[% itemtypeloo.value %]" selected="selected">[% itemtypeloo.description %]</option> >- [% ELSE %] >- <option value="[% itemtypeloo.value %]">[% itemtypeloo.description %]</option> >- [% END %] >- [% END %] >- </select></li> >- --> > </ol></fieldset> > <fieldset class="action"> <input type="submit" value="Submit" /> > <input type="hidden" name="run_report" value="1" /></fieldset> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18881
:
64726
|
64761
|
64769
| 64770