From 24e66fdb22f9a2537dd6ff1608a0f2f5fc561891 Mon Sep 17 00:00:00 2001 From: Aleisha Amohia Date: Thu, 13 Jul 2017 04:30:47 +0000 Subject: [PATCH] Bug 18932: Implementing rules for validating number fields for borrower info The fields I've added validation for are (in both OPAC and staff client): - phone - secondary phone - other phone - fax - zipcode - alt address zipcode - alt address phone - alt contact zipcode - alt contact phone - SMS number (messaging preferences, may have to enable the EnhancedMessagingPreferences and EnhancedMessagingPreferencesOPAC sysprefs to see this) To test: 1) In staff client, add a new patron or edit an existing one. Confirm that attempting to enter symbols or letters in the above fields prevents form submission 2) In OPAC, log in and edit your personal details. Confirm that attempting to enter symbols or letters in the above fields prevents form submission. 3) Go to your messaging preferences and confirm you can only save numbers in the SMS number field Sponsored-by: Catalyst IT --- koha-tmpl/intranet-tmpl/prog/js/members.js | 32 +++++++++++++++++++++- .../bootstrap/en/modules/opac-memberentry.tt | 27 ++++++++++++++++++ .../bootstrap/en/modules/opac-messaging.tt | 18 ++++++++++++ 3 files changed, 76 insertions(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/js/members.js b/koha-tmpl/intranet-tmpl/prog/js/members.js index 28853b2..52a1e50 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/members.js +++ b/koha-tmpl/intranet-tmpl/prog/js/members.js @@ -334,7 +334,37 @@ $(document).ready(function(){ }, B_email: { email: true - } + }, + phone: { + number: true + }, + phonepro: { + number: true + }, + mobile: { + number: true + }, + fax: { + number: true + }, + zipcode: { + number: true + }, + B_zipcode: { + number: true + }, + B_phone: { + number: true + }, + altcontactzipcode: { + number: true + }, + altcontactphone: { + number: true + }, + SMSnumber: { + number: true + }, }, submitHandler: function(form) { $("body, form input[type='submit'], form button[type='submit'], form a").addClass('waiting'); diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt index 231e2bf..3b5d4a3 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt @@ -1011,6 +1011,33 @@ }, borrower_B_email: { email: true + }, + borrower_zipcode: { + number: true + }, + borrower_phone: { + number: true + }, + borrower_phonepro: { + number: true + }, + borrower_mobile: { + number: true + }, + borrower_fax: { + number: true + }, + borrower_B_zipcode: { + number: true + }, + borrower_B_phone: { + number: true + }, + borrower_altcontactzipcode: { + number: true + }, + borrower_altcontactphone: { + number: true } }, submitHandler: function(form) { diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt index 84cb228..6257277 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt @@ -161,6 +161,7 @@ [% INCLUDE 'opac-bottom.inc' %] [% BLOCK jsinclude %] +