From 977d8eaeb7301f85382f91a1fc57dfab1d757da0 Mon Sep 17 00:00:00 2001 From: Mark Tompsett Date: Wed, 7 Jun 2017 12:53:52 -0400 Subject: [PATCH] Bug 18748: Noisy t/db_dependent/AuthorisedValues.t Content-Type: text/plain; charset=utf-8 This noise is from a failure. This patch expands the delete to 952$c for the ACQ framework as per comment #5. TEST PLAN --------- insert into marc_subfield_structure (tagfield,tagsubfield,liblibrarian, libopac, repeatable, mandatory, kohafield,tab,authorised_value,authtypecode,value_builder,isurl,hidden,frameworkcode,seealso,link,defaultvalue,maxlength) values (952,'c','Shelving location','Shelving location',0,0,'items.location',10,'LOC','','',0,0,'ACQ','','',null,9999); -- this makes sure you have a pre-existing 952$c ACQ record. prove t/db_dependent/AuthorisedValues.t -- should have ugly message like in comment #0 apply patch prove t/db_dependent/AuthorisedValues.t -- should be green run koha qa test tools Signed-off-by: Lee Jamison Signed-off-by: Marcel de Rooy --- t/db_dependent/AuthorisedValues.t | 2 ++ 1 file changed, 2 insertions(+) diff --git a/t/db_dependent/AuthorisedValues.t b/t/db_dependent/AuthorisedValues.t index ad5ec60..f7da7a5 100644 --- a/t/db_dependent/AuthorisedValues.t +++ b/t/db_dependent/AuthorisedValues.t @@ -124,6 +124,8 @@ subtest 'search_by_*_field + find_by_koha_field + get_description' => sub { $loc_cat->delete if $loc_cat; my $mss = Koha::MarcSubfieldStructures->search( { tagfield => 952, tagsubfield => 'c', frameworkcode => '' } ); $mss->delete if $mss; + $mss = Koha::MarcSubfieldStructures->search( { tagfield => 952, tagsubfield => 'c', frameworkcode => 'ACQ' } ); + $mss->delete if $mss; $mss = Koha::MarcSubfieldStructures->search( { tagfield => 952, tagsubfield => 'd', frameworkcode => '' } ); $mss->delete if $mss; $mss = Koha::MarcSubfieldStructures->search( { tagfield => 952, tagsubfield => '5', frameworkcode => '' } ); -- 2.1.4