Bugzilla – Attachment 65098 Details for
Bug 18951
Some t/Biblio tests are database dependent
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18951: Adjust Isbd.t
Bug-18951-Adjust-Isbdt.patch (text/plain), 1.67 KB, created by
Lee Jamison
on 2017-07-19 12:43:31 UTC
(
hide
)
Description:
Bug 18951: Adjust Isbd.t
Filename:
MIME Type:
Creator:
Lee Jamison
Created:
2017-07-19 12:43:31 UTC
Size:
1.67 KB
patch
obsolete
>From 8285c350667285b45879e92b24e5260c5c09df3f Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Wed, 19 Jul 2017 13:59:45 +0200 >Subject: [PATCH] Bug 18951: Adjust Isbd.t > >Add schema calls. >Remove an unneeded AddBiblio call. > >Test plan: >Run t/db_dependent/Biblio/Isbd.t > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> > >Signed-off-by: Lee Jamison <ldjamison@marywood.edu> >--- > t/db_dependent/Biblio/Isbd.t | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > >diff --git a/t/db_dependent/Biblio/Isbd.t b/t/db_dependent/Biblio/Isbd.t >index be790e9..4943afe 100644 >--- a/t/db_dependent/Biblio/Isbd.t >+++ b/t/db_dependent/Biblio/Isbd.t >@@ -22,14 +22,14 @@ use Test::MockModule; > use MARC::Record; > use t::lib::Mocks qw( mock_preference ); > >+use Koha::Database; >+ > BEGIN { > use_ok('C4::Biblio'); > } > >-my $dbh = C4::Context->dbh; >-# Start transaction >-$dbh->{AutoCommit} = 0; >-$dbh->{RaiseError} = 1; >+my $schema = Koha::Database->new->schema; >+$schema->storage->txn_begin; > > my $template = '#200|<h2>Title : |{200a}{ by 200f}|</h2>'; > my $opac_template = '#200|<h2>Title : |{200a}{ (200f)}|</h2>'; >@@ -41,10 +41,11 @@ $record->append_fields( > MARC::Field->new('200', '', '', 'a' => 'Mountains'), > MARC::Field->new('200', '', '', 'f' => 'Keith Lye'), > ); >-my ($bibnum, $title, $bibitemnum) = AddBiblio($record, ''); > > my $isbd = GetISBDView({ record => $record }); > is($isbd, '<h2>Title : Mountains by Keith Lye</h2>', 'ISBD is correct'); > > my $opacisbd = GetISBDView({ record => $record, template => 'opac' }); > is($opacisbd, '<h2>Title : Mountains (Keith Lye)</h2>', 'OPAC ISBD is correct'); >+ >+$schema->storage->txn_rollback; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18951
:
65093
|
65094
|
65095
|
65096
|
65097
|
65098
|
65167
|
65168
|
65169