Bugzilla – Attachment 65105 Details for
Bug 18956
Possible privacy breach with OPAC password recovery
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18956: Password recovery - Do not disclose email if not given
Bug-18956-Password-recovery---Do-not-disclose-emai.patch (text/plain), 1.92 KB, created by
Jonathan Druart
on 2017-07-19 16:08:43 UTC
(
hide
)
Description:
Bug 18956: Password recovery - Do not disclose email if not given
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2017-07-19 16:08:43 UTC
Size:
1.92 KB
patch
obsolete
>From 96e65a5f26c279f92483af066de4967a3ca7acf5 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 19 Jul 2017 13:02:01 -0300 >Subject: [PATCH] Bug 18956: Password recovery - Do not disclose email if not > given > >If a patron has started the password recovery process and another user >enter the same login (or cardnumber), without a email address, the >screen will display the email address of the account. > >Test plan: >Given an account with > login: koha > password: whatever > email: koha@k-c.org >Enable the pref OpacResetPassword >At the OPAC, ask for another password: "Forgot your password?" link >Enter the correct login/email >Assume you are somebody else and retry the process, but do not fill the >email field. >=> Without this patch the email will be displayed on the screen >=> With this patch applied you will get "No account was found with the >provided information." > >QA: You will need to understand the condition affected by this patch. >Why was it there? Are we sure we do not introduce a regression with this >patch? >--- > opac/opac-password-recovery.pl | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/opac/opac-password-recovery.pl b/opac/opac-password-recovery.pl >index f4c5e2bd23..d05a78c5ce 100755 >--- a/opac/opac-password-recovery.pl >+++ b/opac/opac-password-recovery.pl >@@ -93,10 +93,10 @@ if ( $query->param('sendEmail') || $query->param('resendEmail') ) { > $errNoBorrowerFound = 1; > } > >-# If we dont have an email yet. Get one of the borrower's email or raise an error. >- elsif ( !$email && !( $email = $firstNonEmptyEmail ) ) { >+# No email has been entered, no recovery possible >+ elsif ( !$email ) { > $hasError = 1; >- $errNoBorrowerEmail = 1; >+ $errNoBorrowerFound = 1; > } > > # Check if a password reset already issued for this borrower AND we are not asking for a new email >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18956
:
65105
|
66026
|
66221
|
66222
|
66491
|
66492
|
66972
|
66973
|
67107
|
67952