View | Details | Raw Unified | Return to bug 18572
Collapse All | Expand All

(-)a/C4/Circulation.pm (-1 / +6 lines)
Lines 2815-2820 sub AddRenewal { Link Here
2815
    my $branch          = shift;
2815
    my $branch          = shift;
2816
    my $datedue         = shift;
2816
    my $datedue         = shift;
2817
    my $lastreneweddate = shift || DateTime->now(time_zone => C4::Context->tz)->ymd();
2817
    my $lastreneweddate = shift || DateTime->now(time_zone => C4::Context->tz)->ymd();
2818
    my $opacrenewal     = shift;
2818
2819
2819
    my $item   = GetItem($itemnumber) or return;
2820
    my $item   = GetItem($itemnumber) or return;
2820
    my $item_object = Koha::Items->find( $itemnumber ); # Should replace $item
2821
    my $item_object = Koha::Items->find( $itemnumber ); # Should replace $item
Lines 2915-2924 sub AddRenewal { Link Here
2915
        DelUniqueDebarment({ borrowernumber => $borrowernumber, type => 'OVERDUES' });
2916
        DelUniqueDebarment({ borrowernumber => $borrowernumber, type => 'OVERDUES' });
2916
    }
2917
    }
2917
2918
2919
    unless ( $opacrenewal ) { #if from opac we are obeying OpacRenewalBranch as calculated in opac-renew.pl
2920
        $branch = C4::Context->userenv ? C4::Context->userenv->{branch} : $branch;
2921
    }
2922
2918
    # Add the renewal to stats
2923
    # Add the renewal to stats
2919
    UpdateStats(
2924
    UpdateStats(
2920
        {
2925
        {
2921
            branch => C4::Context->userenv ? C4::Context->userenv->{branch} : $branch,
2926
            branch         => $branch,
2922
            type           => 'renew',
2927
            type           => 'renew',
2923
            amount         => $charge,
2928
            amount         => $charge,
2924
            itemnumber     => $itemnumber,
2929
            itemnumber     => $itemnumber,
(-)a/opac/opac-renew.pl (-1 / +1 lines)
Lines 82-88 else { Link Here
82
            else {
82
            else {
83
                $branchcode = 'OPACRenew';
83
                $branchcode = 'OPACRenew';
84
            }
84
            }
85
            AddRenewal( $borrowernumber, $itemnumber, $branchcode );
85
            AddRenewal( $borrowernumber, $itemnumber, $branchcode, undef, undef, 1 );
86
            push( @renewed, $itemnumber );
86
            push( @renewed, $itemnumber );
87
        }
87
        }
88
        else {
88
        else {
(-)a/t/db_dependent/Circulation/issue.t (-2 / +16 lines)
Lines 17-23 Link Here
17
17
18
use Modern::Perl;
18
use Modern::Perl;
19
19
20
use Test::More tests => 30;
20
use Test::More tests => 31;
21
use DateTime::Duration;
21
use DateTime::Duration;
22
22
23
use t::lib::Mocks;
23
use t::lib::Mocks;
Lines 230-235 like( Link Here
230
my $stat = $dbh->selectrow_hashref("SELECT * FROM statistics WHERE type = 'renew' AND borrowernumber = ? AND itemnumber = ? AND branch = ?", undef, $borrower_id1, $item_id1, $branchcode_3 );
230
my $stat = $dbh->selectrow_hashref("SELECT * FROM statistics WHERE type = 'renew' AND borrowernumber = ? AND itemnumber = ? AND branch = ?", undef, $borrower_id1, $item_id1, $branchcode_3 );
231
ok( $stat, "Bug 17781 - 'Improper branchcode set during renewal' still fixed" );
231
ok( $stat, "Bug 17781 - 'Improper branchcode set during renewal' still fixed" );
232
232
233
#Let's do an opac renewal - whatever branchcode we send should be used
234
my $opac_renew_issue = $builder->build({ source=>"Issue",value=>{
235
        date_due => '2017-01-01',
236
        branch => $branchcode_1,
237
        itype => $itemtype,
238
        borrowernumber => $borrower_id1
239
        }
240
        });
241
242
my $datedue4 = AddRenewal( $opac_renew_issue->{borrowernumber}, $opac_renew_issue->{itemnumber}, "Stavromula", $datedue1, $daysago10, 1 );
243
244
$stat = $dbh->selectrow_hashref("SELECT * FROM statistics WHERE type = 'renew' AND borrowernumber = ? AND itemnumber = ? AND branch = ?", undef,  $opac_renew_issue->{borrowernumber},  $opac_renew_issue->{itemnumber}, "Stavromula" );
245
ok( $stat, "Bug 18572 - 'Bug 18572 - OpacRenewalBranch is now respected" );
246
247
233
248
234
#Test GetBiblioIssues
249
#Test GetBiblioIssues
235
is( GetBiblioIssues(), undef, "GetBiblio Issues without parameters" );
250
is( GetBiblioIssues(), undef, "GetBiblio Issues without parameters" );
236
- 

Return to bug 18572